Bug 30389 - Switch to Bootstrap tabs on the page for adding orders from MARC file
Summary: Switch to Bootstrap tabs on the page for adding orders from MARC file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30388
Blocks:
  Show dependency treegraph
 
Reported: 2022-03-28 19:13 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file (78.49 KB, patch)
2022-03-28 19:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file (78.64 KB, patch)
2022-04-01 07:49 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file (77.30 KB, patch)
2022-07-26 15:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file (77.35 KB, patch)
2022-07-28 21:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-03-28 19:13:20 UTC
Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the 'Add orders from MARC file' page with Bootstrap tabs
Comment 1 Owen Leonard 2022-03-28 19:25:12 UTC Comment hidden (obsolete)
Comment 2 Séverine Queune 2022-04-01 07:49:11 UTC Comment hidden (obsolete)
Comment 3 Séverine Queune 2022-04-01 07:50:10 UTC
Really nice Owen !
The alignment of the first tab is really better with the patch.
Comment 4 Katrin Fischer 2022-04-03 10:39:18 UTC
I am afraid this is not quite ready for QA yet with the 2 dependent bugs not yet signed off. Moving to BLOCKED, back to QA queue soon.
Comment 5 Owen Leonard 2022-07-26 15:09:17 UTC
Created attachment 138133 [details] [review]
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file

This patch updates addorderiso2709.tt so that it uses Bootstrap tabs
intead of jQuery.

The patch contains indentation changes, so diff accordingly.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that the tabs work correctly.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Comment 6 Katrin Fischer 2022-07-28 21:46:13 UTC
Created attachment 138235 [details] [review]
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file

This patch updates addorderiso2709.tt so that it uses Bootstrap tabs
intead of jQuery.

The patch contains indentation changes, so diff accordingly.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that the tabs work correctly.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2022-07-29 19:10:51 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-09-29 15:02:45 UTC
Missing 22.05.x dependencies, no backport