Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the holds template with Bootstrap.
Created attachment 132980 [details] [review] Bug 30457: Convert holds page tabs to Bootstrap This patch updates the holds page to replace jQueryUI tabs with Bootstrap. To test, apply the patch and begin the process of placing a hold on a title in the catalog. If you have one or more patron clubs configured: - You should see two tabs, Patrons and Clubs. - Both should look correct and work correctly. - The Patrons tab should be selected initially, with cursor focus in the form field. - Switch to the Clubs tab. The cursor focus should move to the form field under this tab. - Submit a club search which will return results. - The page should refresh and the clubs tab should be preselected, showing the search results. If you have no patron clubs configured, the page should show only the Patrons tab.
Created attachment 133088 [details] [review] Bug 30457: Convert holds page tabs to Bootstrap This patch updates the holds page to replace jQueryUI tabs with Bootstrap. To test, apply the patch and begin the process of placing a hold on a title in the catalog. If you have one or more patron clubs configured: - You should see two tabs, Patrons and Clubs. - Both should look correct and work correctly. - The Patrons tab should be selected initially, with cursor focus in the form field. - Switch to the Clubs tab. The cursor focus should move to the form field under this tab. - Submit a club search which will return results. - The page should refresh and the clubs tab should be preselected, showing the search results. If you have no patron clubs configured, the page should show only the Patrons tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Hi, tabs are not aligned correctly on my testing: https://snipboard.io/lqO09T.jpg
Confirmed, alignment is out
Created attachment 133491 [details] [review] Bug 30457: (follow-up) Tweak markup around search form This patch makes a change to the markup around the patron/clubs search form on the holds page. This change prevents the Bootstrap tabs from inheriting an unwanted margin from the fieldset.brief definition. The change also replaces a <label> tag with an <h2>. I think a heading makes more sense than a free-floating <label>. To test, apply the patch and confirm that the holds page (/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct.
Created attachment 133493 [details] [review] Bug 30457: Convert holds page tabs to Bootstrap This patch updates the holds page to replace jQueryUI tabs with Bootstrap. To test, apply the patch and begin the process of placing a hold on a title in the catalog. If you have one or more patron clubs configured: - You should see two tabs, Patrons and Clubs. - Both should look correct and work correctly. - The Patrons tab should be selected initially, with cursor focus in the form field. - Switch to the Clubs tab. The cursor focus should move to the form field under this tab. - Submit a club search which will return results. - The page should refresh and the clubs tab should be preselected, showing the search results. If you have no patron clubs configured, the page should show only the Patrons tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 133494 [details] [review] Bug 30457: (follow-up) Tweak markup around search form This patch makes a change to the markup around the patron/clubs search form on the holds page. This change prevents the Bootstrap tabs from inheriting an unwanted margin from the fieldset.brief definition. The change also replaces a <label> tag with an <h2>. I think a heading makes more sense than a free-floating <label>. To test, apply the patch and confirm that the holds page (/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Excellent, thanks for the quick follow-up. PQA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]