Bug 30458 - Librarian ( manager_id ) not included in accountline when using "Payout amount" button
Summary: Librarian ( manager_id ) not included in accountline when using "Payout amoun...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Joonas Kylmälä
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 13:38 UTC by Kyle M Hall
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00,21.11, 22.05.05


Attachments
Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button (1.39 KB, patch)
2022-04-05 13:43 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button (1.46 KB, patch)
2022-07-20 09:21 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button (1.62 KB, patch)
2022-07-20 18:33 UTC, Joonas Kylmälä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2022-04-05 13:38:50 UTC

    
Comment 1 Kyle M Hall 2022-04-05 13:43:37 UTC
Created attachment 132976 [details] [review]
Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!
Comment 2 Lucas Gass 2022-05-18 22:06:33 UTC
When I do steps 1-3 I do see a manager_id without this patch. Here is what I am doing when I look:

select manager_id from accountlines where debit_type_code = 'PAYOUT';


Am I doing something wrong?
Comment 3 Kyle M Hall 2022-05-23 18:56:54 UTC
(In reply to Lucas Gass from comment #2)
> When I do steps 1-3 I do see a manager_id without this patch. Here is what I
> am doing when I look:
> 
> select manager_id from accountlines where debit_type_code = 'PAYOUT';
> 
> 
> Am I doing something wrong?

I wonder if this bug only exists in Koha 21.05.x, and not in master.
Comment 4 Biblibre Sandboxes 2022-07-20 09:21:56 UTC
Created attachment 137905 [details] [review]
Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 5 Sally 2022-07-20 09:37:48 UTC
I can replicate on master (the manager_id shows if 'issue payout' is used on the individual line, but doesn't show if the 'payout amount' button at the bottom of the lines is used).  

After replicating the bug, I've tested the patch and it works - so signing off.  Thanks for the patch.
Comment 6 Katrin Fischer 2022-07-20 09:54:02 UTC
(In reply to Sally from comment #5)
> I can replicate on master (the manager_id shows if 'issue payout' is used on
> the individual line, but doesn't show if the 'payout amount' button at the
> bottom of the lines is used).  
> 
> After replicating the bug, I've tested the patch and it works - so signing
> off.  Thanks for the patch.

Thanks for testing, Sally! (in general, but for this one too)
Comment 7 Joonas Kylmälä 2022-07-20 18:33:21 UTC
Created attachment 137949 [details] [review]
Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
JK: Fix commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 8 Joonas Kylmälä 2022-07-20 18:34:33 UTC
Thanks, trivial fix, passing QA. Adjusted the commit title a bit as it was not passing the qa tool and didn't describe the change.
Comment 9 Tomás Cohen Arazi 2022-07-21 19:05:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Lucas Gass 2022-09-02 14:58:41 UTC
Backported to 22.05.x for 22.05.05
Comment 11 Arthur Suzuki 2022-09-14 12:58:34 UTC
Thanks!

Pushed to 21.11 for 21.11.12
Comment 12 Victor Grousset/tuxayo 2022-09-19 21:02:17 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.