Bug 30459 - BatchDeleteAuthority task does not deal with indexation correctly
Summary: BatchDeleteAuthority task does not deal with indexation correctly
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 27344
Blocks: 27341
  Show dependency treegraph
 
Reported: 2022-04-06 09:27 UTC by Jonathan Druart
Modified: 2022-12-12 21:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30459: Make BatchDeleteAuthority update the index in one request (3.50 KB, patch)
2022-04-06 11:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30459: Make BatchDeleteAuthority update the index in one request (3.49 KB, patch)
2022-04-29 17:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 30459: Make BatchDeleteAuthority update the index in one request (3.56 KB, patch)
2022-05-05 14:51 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-04-06 09:27:23 UTC
Indexation must be done at the end of the process, when all authorities have been deleted, not for each authority record.
Comment 1 Jonathan Druart 2022-04-06 11:55:54 UTC
Created attachment 132991 [details] [review]
Bug 30459: Make BatchDeleteAuthority update the index in one request

Same as bug 30460 for authorities
Comment 2 Tomás Cohen Arazi 2022-04-29 17:15:06 UTC
Created attachment 134399 [details] [review]
Bug 30459: Make BatchDeleteAuthority update the index in one request

Same as bug 30460 for authorities
Comment 3 Martin Renvoize 2022-05-05 14:51:35 UTC
Created attachment 134647 [details] [review]
Bug 30459: Make BatchDeleteAuthority update the index in one request

Same as bug 30460 for authorities

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-05-05 14:52:59 UTC
I'm torn by these patches.. they all improve reliability/reduce the possibility of overwhelming elasticsearch.. but they do so at the detriment of zebra by delaying indexing.

As the general movement seems to be towards ES I'm going to PQA regardless :|
Comment 5 Fridolin Somers 2022-05-05 21:20:59 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄