Bug 3046 - System ignores MaxFine syspref
Summary: System ignores MaxFine syspref
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: rel_3_0
Hardware: PC All
: P5 - low major
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-19 01:39 UTC by Jane Wagner
Modified: 2012-10-25 22:52 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:05:46 UTC


---- Reported by jwagner@ptfs.com 2009-03-19 13:39:47 ----

Setting the syspref MaxFine has no effect on fine calculation.  Overdues.pm has a call to that syspref, but it was entered as maxFine instead of MaxFine.  I tried correcting the case, but it had no effect -- fines keep accumulating past the ceiling.  It also looks like the script is meant to apply the MaxFine ceiling to each item's fines, instead of to the overall total fine amount.

A fix is needed to (a) make the system obey the MaxFine ceiling, and (b) to apply it to the fine total instead of each item.  The second one may need to be optional -- some sites might want to use the setting per item, while others want it to apply to the total.



---- Additional Comments From adrea@moablibrary.org 2009-05-04 21:07:32 ----

Our library would very much like to see this system preference working.  When it is working we vote for having the option to cap the fine for an individual item.



---- Additional Comments From arm@hanover.ca 2009-05-19 16:53:15 ----

(In reply to comment #0)
>...  It also looks like the script is meant to apply the MaxFine
> ceiling to each item's fines, instead of to the overall total fine amount.
> 
> A fix is needed to (a) make the system obey the MaxFine ceiling, and (b) to
> apply it to the fine total instead of each item.  The second one may need to be
> optional -- some sites might want to use the setting per item, while others
> want it to apply to the total.
> 

From the Preferences description "Maximum fine a patron can have for a single late return" I understood this was meant to be the fine ceiling for each item. My library needs a max fine per item more than an overall fine per patron. However, I have another suggestion... 

Would it be possible to set the max fine per item in the "Circulation and fines rules" table. This is where the fine "rate" is set, per item type, and would allow libraries to choose different max fine levels for different item types.

If this could be done, it would then make sense for the circulation preference to be an overall max fine per patron (borrower), and then the wording of the description should be changed to reflect this.



---- Additional Comments From katrin.fischer@bsz-bw.de 2009-12-01 08:16:34 ----

Syspref MaxFine is still broken in 3.01.00.061.

We would also prefer a limit per item. 

Possibility to set MaxFine in circ matrix would allow more flexibility for short loans and long term loans with different grace periods and fine charging intervals.



---- Additional Comments From katrin.fischer@bsz-bw.de 2009-12-01 08:55:03 ----

Is it possible the problem only occurs when fine charging interval is > 1?

For my test cases with fine charging interval = 1 fine accumulation stops at value set in MaxFine.



---- Additional Comments From katrin.fischer@bsz-bw.de 2010-04-23 10:49:27 ----

I was not able to reproduce this error in my following tests.

I think the problem was caused by changing the fine configuration and only for items that had already fines and had not reached the limit.




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:05 UTC  ---

This bug was previously known as _bug_ 3046 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3046

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
CC member adrea@moablibrary.org does not have an account here
CC member arm@hanover.ca does not have an account here

Comment 1 Katrin Fischer 2010-07-28 13:43:16 UTC
Closing bug.

I did extensive fine testing in 3.1 and the problem does not occur in this version. The only time I was having problems it was caused by configuration changes.

According to hdl this is not a problem in 3.0.x

Please reopen if you still see any problems with the MaxFines.

There is development in Harly for MaxFine in circ matrix and other enhancements, see Bug 3507