Bug 30471 - Typo in circulation rules - lost item fee refund policy
Summary: Typo in circulation rules - lost item fee refund policy
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Joonas Kylmälä
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-06 13:49 UTC by Nick Clemens (kidclamp)
Modified: 2023-06-08 22:26 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00,21.11, 22.05.05


Attachments
Bug 30471: Correct display of default rules (2.17 KB, patch)
2022-04-06 13:51 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 30471: Correct display of default rules (2.23 KB, patch)
2022-07-21 11:19 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 30471: Correct display of default rules (2.30 KB, patch)
2022-07-21 12:04 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 30471: Correct display of default rules (2.44 KB, patch)
2022-07-21 16:04 UTC, Joonas Kylmälä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-04-06 13:49:29 UTC
When setting a rules for a specific branch the default rule is displayed incorrectly

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
Comment 1 Nick Clemens (kidclamp) 2022-04-06 13:51:22 UTC
Created attachment 133028 [details] [review]
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly
Comment 2 Sara Brown 2022-04-06 14:11:20 UTC
This appears to happen when the 'Standard' rule is 'Refund lost item charge and charge new overdue fine' (displayed for branches as 'Use default (Refund lost item charge and restore overdue fine)') or 'Refund lost item charge and restore overdue fine' (displayed for branches as 'Use default 'Refund lost item charge and charge new overdue fine)'. Branches display correctly when the 'Standard' is 'Leave lost item charge' or 'Refund lost item charge'.
Comment 3 Sally 2022-07-21 08:08:05 UTC
Bug still valid - but patch no longer applies.
Comment 4 Nick Clemens (kidclamp) 2022-07-21 11:19:45 UTC
Created attachment 137958 [details] [review]
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly
Comment 5 Biblibre Sandboxes 2022-07-21 12:04:27 UTC
Created attachment 137959 [details] [review]
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 6 Sally 2022-07-21 12:05:04 UTC
Great, thanks Nick - works as described, signing off.
Comment 7 Joonas Kylmälä 2022-07-21 16:04:48 UTC
Created attachment 137986 [details] [review]
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 8 Tomás Cohen Arazi 2022-07-21 19:05:06 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass 2022-09-02 14:55:48 UTC
Backported to 22.05.x for 22.05.05
Comment 10 Arthur Suzuki 2022-09-14 12:58:39 UTC
Thanks!

Pushed to 21.11 for 21.11.12
Comment 11 Victor Grousset/tuxayo 2022-09-19 20:49:05 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.