Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the suggestions template with Bootstrap.
Created attachment 133044 [details] [review] Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar.
Everything works as described. I have no very minor complaint: Before the patch there is some padding-top of the UI tabs which gives them a little bit of space after the select dropdown. ( #branchcode ) With the patch there is no padding and the select dropdown sits right on top of the tabs.
(In reply to Lucas Gass from comment #2) > Everything works as described. I have no very minor complaint: > > Before the patch there is some padding-top of the UI tabs which gives them a > little bit of space after the select dropdown. ( #branchcode ) > > With the patch there is no padding and the select dropdown sits right on top > of the tabs. It's a very nit-picky problem and not enough to 'Fail QA' imo, so I am signing off.
Created attachment 133182 [details] [review] Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Lucas Gass from comment #2) > With the patch there is no padding and the select dropdown sits right on top > of the tabs. The fix for this is in Bug 30466. I didn't make them dependent because it's such a small thing.
Created attachment 133484 [details] [review] Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great to hear my only concern is already fixed in bug 30466.. PQA
Hi, With this patch, if table has no content, you see a rectangle. Looks like this comes from : + <div class="tab-content">
(In reply to Fridolin Somers from comment #8) > Hi, > > With this patch, if table has no content, you see a rectangle. > Looks like this comes from : > + <div class="tab-content"> This is really minor, it can be done later. Patch needs rebase please.
Created attachment 134611 [details] [review] Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Lets push like this. I try to have all bugs of this topic in 22.05 release
Pushed to master for 22.05, thanks to everybody involved [U+1F984]