Bug 30485 - Searching all patrons from the header does not display the patron search view
Summary: Searching all patrons from the header does not display the patron search view
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 30063
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-07 12:24 UTC by Jonathan Druart
Modified: 2022-12-12 21:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30485: (bug 30063 follow-up) Display all patrons if not term passed (3.17 KB, patch)
2022-04-07 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30485: (bug 30063 follow-up) Display all patrons if not term passed (3.26 KB, patch)
2022-04-07 12:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-04-07 12:24:31 UTC
Regression from bug 30063. If you are searching all patrons (not search term passed) from the header, the patron search result is not displayed.
Comment 1 Jonathan Druart 2022-04-07 12:26:52 UTC
Created attachment 133077 [details] [review]
Bug 30485: (bug 30063 follow-up) Display all patrons if not term passed

Regression from bug 30063. If you are searching all patrons (not search term passed) from the header, the patron search result is not displayed.

Test plan:
Go to the Koha homepage, search patrons, don't enter a search term and
click "submit"
All patrons must be returned.
Regression test: on the other patron search forms, confirm that there is
no regression, ie. no patron displayed until you search for something
Comment 2 Marcel de Rooy 2022-04-07 12:27:33 UTC
Let me have a look :)
Comment 3 Marcel de Rooy 2022-04-07 12:31:09 UTC
Created attachment 133078 [details] [review]
Bug 30485: (bug 30063 follow-up) Display all patrons if not term passed

Regression from bug 30063. If you are searching all patrons (not search term passed) from the header, the patron search result is not displayed.

Test plan:
Go to the Koha homepage, search patrons, don't enter a search term and
click "submit"
All patrons must be returned.
Regression test: on the other patron search forms, confirm that there is
no regression, ie. no patron displayed until you search for something

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2022-04-07 12:31:51 UTC
Taking the liberty to combine with QA: trivial change.
Comment 5 Fridolin Somers 2022-04-13 13:58:38 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄