Bug 30487 - Convert checkout and patron details page tabs to Bootstrap
Summary: Convert checkout and patron details page tabs to Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 29226
  Show dependency treegraph
 
Reported: 2022-04-07 13:25 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 30487: Convert checkout and patron details page tabs to Bootstrap (46.91 KB, patch)
2022-10-11 16:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30487: Convert checkout and patron details page tabs to Bootstrap (46.96 KB, patch)
2022-10-11 22:18 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30487: Convert checkout and patron details page tabs to Bootstrap (47.00 KB, patch)
2022-10-14 15:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30487: Compiled CSS (144.90 KB, patch)
2022-10-17 11:57 UTC, Thibaud Guillot
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-04-07 13:25:52 UTC
Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in two places:

- circ/circulation.tt
- members/moremember.tt
Comment 1 Owen Leonard 2022-10-11 16:21:27 UTC
Created attachment 141612 [details] [review]
Bug 30487: Convert checkout and patron details page tabs to Bootstrap

This patch updates the checkout and patron details pages, updating
jQueryUI tabs to Bootstrap tabs.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Circulation -> Check out and load a patron record for checkout.
Ideally the patron record should have a variet of data associated with
it:

 - Checkouts
 - Relative's checkouts (if patron is a guarantor or guarantee to
   another patron with checkouts)
 - Holds
 - Article requests
 - Claims
 - Restrictions
 - Clubs

On the patron's checkout page, test the various tabs corresponding to
the features listed above. Having data to display in those tabs helps
confirm that any table functionality triggered by the tab activation is
working correctly.

The checkouts tab should work correctly whether you have "Always show
checkouts immediately" checked or not.

Test that you can pre-select any tab by appending its anchor to the URL,
e.g.:

/cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves

Perform the same checks on the patron details page.
Comment 2 Lucas Gass 2022-10-11 22:18:37 UTC
Created attachment 141624 [details] [review]
Bug 30487: Convert checkout and patron details page tabs to Bootstrap

This patch updates the checkout and patron details pages, updating
jQueryUI tabs to Bootstrap tabs.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Circulation -> Check out and load a patron record for checkout.
Ideally the patron record should have a variet of data associated with
it:

 - Checkouts
 - Relative's checkouts (if patron is a guarantor or guarantee to
   another patron with checkouts)
 - Holds
 - Article requests
 - Claims
 - Restrictions
 - Clubs

On the patron's checkout page, test the various tabs corresponding to
the features listed above. Having data to display in those tabs helps
confirm that any table functionality triggered by the tab activation is
working correctly.

The checkouts tab should work correctly whether you have "Always show
checkouts immediately" checked or not.

Test that you can pre-select any tab by appending its anchor to the URL,
e.g.:

/cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves

Perform the same checks on the patron details page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Martin Renvoize 2022-10-14 15:16:41 UTC
Created attachment 141894 [details] [review]
Bug 30487: Convert checkout and patron details page tabs to Bootstrap

This patch updates the checkout and patron details pages, updating
jQueryUI tabs to Bootstrap tabs.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Circulation -> Check out and load a patron record for checkout.
Ideally the patron record should have a variet of data associated with
it:

 - Checkouts
 - Relative's checkouts (if patron is a guarantor or guarantee to
   another patron with checkouts)
 - Holds
 - Article requests
 - Claims
 - Restrictions
 - Clubs

On the patron's checkout page, test the various tabs corresponding to
the features listed above. Having data to display in those tabs helps
confirm that any table functionality triggered by the tab activation is
working correctly.

The checkouts tab should work correctly whether you have "Always show
checkouts immediately" checked or not.

Test that you can pre-select any tab by appending its anchor to the URL,
e.g.:

/cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves

Perform the same checks on the patron details page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-10-14 15:17:44 UTC
Nice work, no regressions found.

Passing QA
Comment 5 Tomás Cohen Arazi 2022-10-17 11:08:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Thibaud Guillot 2022-10-17 11:57:30 UTC
Created attachment 141959 [details] [review]
Bug 30487: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>