Bug 30523 - Quiet console warning about missing shortcut-buttons map file
Summary: Quiet console warning about missing shortcut-buttons map file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-13 12:17 UTC by Owen Leonard
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01, 21.11.07


Attachments
Bug 30523: Quiet console warning about missing shortcut-buttons map file (6.84 KB, patch)
2022-04-14 12:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30523: Quiet console warning about missing shortcut-buttons map file (6.89 KB, patch)
2022-05-15 22:34 UTC, David Nind
Details | Diff | Splinter Review
Bug 30523: Quiet console warning about missing shortcut-buttons map file (7.00 KB, patch)
2022-05-15 22:55 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-04-13 12:17:54 UTC
The Flatpickr addon shortcut-buttons-flatpickr includes a line referring to a non-existent map file:

//# sourceMappingURL=shortcut-buttons-flatpickr.min.js.map

I propose removing this line, and updating the addon to the latest version while I'm at it.
Comment 1 Owen Leonard 2022-04-14 12:05:18 UTC
Created attachment 133305 [details] [review]
Bug 30523: Quiet console warning about missing shortcut-buttons map file

This patch updates the Flatpickr plugin shortcut-buttons which adds the
"Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets.  This
updates it to the latest version, 0.4.0.

The file is modified in two ways: The version information is added to
the top of the file, and the sourceMappingURL line is removed from the
bottom. This quiets browser console warnings about a missing map file.

To test, apply the patch and clear your browser cache.

- Go to Circulation -> Check out and check out to a patron.
- Click "Checkout settings" and click the "Specify due date" field.
- In the pop-up calendar, test all controls, including the shortcut
  links, to confirm that everything works as before.
- In the browser console there should be no warning related to
  shortcut-buttons-flatpickr.
Comment 2 David Nind 2022-05-15 22:34:48 UTC
Created attachment 135009 [details] [review]
Bug 30523: Quiet console warning about missing shortcut-buttons map file

This patch updates the Flatpickr plugin shortcut-buttons which adds the
"Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets.  This
updates it to the latest version, 0.4.0.

The file is modified in two ways: The version information is added to
the top of the file, and the sourceMappingURL line is removed from the
bottom. This quiets browser console warnings about a missing map file.

To test, apply the patch and clear your browser cache.

- Go to Circulation -> Check out and check out to a patron.
- Click "Checkout settings" and click the "Specify due date" field.
- In the pop-up calendar, test all controls, including the shortcut
  links, to confirm that everything works as before.
- In the browser console there should be no warning related to
  shortcut-buttons-flatpickr.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2022-05-15 22:55:45 UTC
Created attachment 135012 [details] [review]
Bug 30523: Quiet console warning about missing shortcut-buttons map file

This patch updates the Flatpickr plugin shortcut-buttons which adds the
"Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets.  This
updates it to the latest version, 0.4.0.

The file is modified in two ways: The version information is added to
the top of the file, and the sourceMappingURL line is removed from the
bottom. This quiets browser console warnings about a missing map file.

To test:
- apply the patch and clear your browser cache.
- Go to Circulation -> Check out and check out to a patron.
- Click "Checkout settings" and click the "Specify due date" field.
- In the pop-up calendar, test all controls, including the shortcut
  links, to confirm that everything works as before.
- In the browser console there should be no warning related to
  shortcut-buttons-flatpickr. (Firefox didn't have the warning, Chromium
  can be used.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2022-05-15 22:57:31 UTC
Works, qa script happy, code looks good, passing QA :)
Comment 5 Tomás Cohen Arazi 2022-06-02 12:52:40 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-06-10 16:29:01 UTC
Pushed to 22.05.x for 22.05.01
Comment 7 Arthur Suzuki 2022-06-21 13:31:13 UTC
Thx! pushed to 21.11.x for 21.11.07
Comment 8 Victor Grousset/tuxayo 2022-06-25 23:55:08 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.