The Flatpickr addon shortcut-buttons-flatpickr includes a line referring to a non-existent map file: //# sourceMappingURL=shortcut-buttons-flatpickr.min.js.map I propose removing this line, and updating the addon to the latest version while I'm at it.
Created attachment 133305 [details] [review] Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test, apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr.
Created attachment 135009 [details] [review] Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test, apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135012 [details] [review] Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test: - apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr. (Firefox didn't have the warning, Chromium can be used. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
Thx! pushed to 21.11.x for 21.11.07
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.