30604 – Add value builders for UNIMARC 146 ($a, $h and $i)

Bug 30604 - Add value builders for UNIMARC 146 ($a, $h and $i)

Summary: Add value builders for UNIMARC 146 ($a, $h and $i)

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Cataloging (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Julian Maurice
QA Contact:	Marcel de Rooy

URL:
Keywords:

Depends on:
Blocks:

Reported:	2022-04-25 09:22 UTC by Julian Maurice
Modified:	2023-12-28 20:42 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	This enhancement for UNIMARC field 146 adds value builders for subfields $a, $h, and $i. These are based on the official UNIMARC codes.
Version(s) released in:	22.05.00
Circulation function:

Attachments
Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i) (19.48 KB, patch) 2022-04-25 09:42 UTC, Julian Maurice	Details \| Diff \| Splinter Review
Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i) (19.53 KB, patch) 2022-05-01 21:24 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i) (19.63 KB, patch) 2022-05-06 09:54 UTC, Marcel de Rooy	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julian Maurice 2022-04-25 09:22:38 UTC

Comment 1 Julian Maurice 2022-04-25 09:42:28 UTC

Created attachment 133727 [details] [review]
Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i)

Test plan:
1. Configure the default MARC framework to use those value builders:
   - unimarc_field_146a for 146$a
   - unimarc_field_146h for 146$h
   - unimarc_field_146i for 146$i
2. Verify that they all work correctly according to
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf

Comment 2 David Nind 2022-05-01 21:24:10 UTC

Created attachment 134445 [details] [review]
Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i)

Test plan:
1. Configure the default MARC framework to use those value builders:
   - unimarc_field_146a for 146$a
   - unimarc_field_146h for 146$h
   - unimarc_field_146i for 146$i
2. Verify that they all work correctly according to
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Marcel de Rooy 2022-05-06 09:29:57 UTC

QAing

Comment 4 Marcel de Rooy 2022-05-06 09:54:54 UTC

Created attachment 134718 [details] [review]
Bug 30604: Add value builders for UNIMARC 146 ($a, $h and $i)

Test plan:
1. Configure the default MARC framework to use those value builders:
   - unimarc_field_146a for 146$a
   - unimarc_field_146h for 146$h
   - unimarc_field_146i for 146$i
2. Verify that they all work correctly according to
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 5 Fridolin Somers 2022-05-06 20:34:45 UTC

Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑