On the register details page in cash management, we display a table of transactions. Right now, the printReceipt button is bound to tightly and as such when you navigate around the transactions table and onto the second page of results the "Print receipt" button stops working.
Created attachment 133811 [details] [review] Bug 30610: Update on click binding for print receipt This patch updates the binding for the on click even of the print receipt button so that subsequent pages in the datatable work with the reciept printing button. Test plan 1) Enable cash management and process enough transactions to display more than one page of transactions in the register details page. 2) Confirm the 'Print receipt' button works on the first page of transactions 3) Confirm the 'Print receipt' button works on subsequent transactions pages in the datatable. 4) Confirm the same for the past transactions table.
Created attachment 133843 [details] [review] Bug 30610: Update on click binding for print receipt This patch updates the binding for the on click even of the print receipt button so that subsequent pages in the datatable work with the reciept printing button. Test plan 1) Enable cash management and process enough transactions to display more than one page of transactions in the register details page. 2) Confirm the 'Print receipt' button works on the first page of transactions 3) Confirm the 'Print receipt' button works on subsequent transactions pages in the datatable. 4) Confirm the same for the past transactions table. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133875 [details] [review] Bug 30610: Update on click binding for print receipt This patch updates the binding for the on click even of the print receipt button so that subsequent pages in the datatable work with the reciept printing button. Test plan 1) Enable cash management and process enough transactions to display more than one page of transactions in the register details page. 2) Confirm the 'Print receipt' button works on the first page of transactions 3) Confirm the 'Print receipt' button works on subsequent transactions pages in the datatable. 4) Confirm the same for the past transactions table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I think we can/should trust Owens SO here as a QA stamp ;). I have double-checked my work and can confirm I've run the QA script against it and it's happy.. (And we now have this in live running at a site) Updating the status, thanks for testing Owen. :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.06
Backported: Pushed to 21.05.x branch for 21.05.16
Bugfix only, no functional changes so no documentation update required.