Koha requires that you be logged in to the OPAC in order to view a private list. This is true from the RSS view of a private list as well. We don't provide an alternative authentication method to enable access by RSS readers. Unless and until someone develops a means to provide RSS access to private lists it is logical to hide the RSS icon when viewing a private list.
Created attachment 134641 [details] [review] Bug 30613: Hide RSS feed link when viewing private list in the OPAC This patch wraps the List RSS icon in a check on whether the list is public. Private lists RSS can only be accessed by a logged-in patron. To test apply the patch and view a public list in the OPAC. You should see an RSS link icon next to the list title. Now log in to the OPAC and view a private list. There should be no RSS link. Note the QA tool warning about the aria-hidden attribute is a false positive. The parent element has a label.
Created attachment 134664 [details] [review] Bug 30613: Hide RSS feed link when viewing private list in the OPAC This patch wraps the List RSS icon in a check on whether the list is public. Private lists RSS can only be accessed by a logged-in patron. To test apply the patch and view a public list in the OPAC. You should see an RSS link icon next to the list title. Now log in to the OPAC and view a private list. There should be no RSS link. Note the QA tool warning about the aria-hidden attribute is a false positive. The parent element has a label. Signed-off-by: David Nind <david@davidnind.com>
Working on this one :)
Created attachment 134677 [details] [review] Bug 30613: Hide RSS feed link when viewing private list in the OPAC This patch wraps the List RSS icon in a check on whether the list is public. Private lists RSS can only be accessed by a logged-in patron. To test apply the patch and view a public list in the OPAC. You should see an RSS link icon next to the list title. Now log in to the OPAC and view a private list. There should be no RSS link. Note the QA tool warning about the aria-hidden attribute is a false positive. The parent element has a label. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]