When searching for a cardnumber that matches exactly an existing cardnumber, the corresponding patron needs to 'found' directly, without displaying a result list. To test: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database - Verify the result list is shown instead of selecting the patron
Created attachment 134073 [details] [review] Bug 30622: Patron search when placing hold should redirect if cardnumber is entered When search a patron for placing a hold, if a cardnumber is entered we should pick the patron and use it, instead of display the table result. This was a regression caused by bug 30063. Test plan: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database
Should this behaviour be applied to some other patron searches?
Can you give an example? I could test if it's a regression with 20.11 or so. But my first reaction would be yes. An exact match on cardnumber or userid should open the patron record directly.
(In reply to Katrin Fischer from comment #3) > Can you give an example? I could test if it's a regression with 20.11 or so. > > But my first reaction would be yes. > > An exact match on cardnumber or userid should open the patron record > directly. An example of what? Of another patron search? Could be guarantor, user for funds or suggestion, etc.
Hi, I have done some testing on an older (20.11.x) version: Cardnumbers for testing: A A1 A2 1) Patron search: A A opens directly 2) Acq > User to notify on receive A shows only one result Tried something else: AA AA2 AA3 AA = 1 result A = 3 results So it seems to limit when exact match. But then you need to click the single result. 3) Place hold Searching for AA selects the user directly. So it seems the behavior was a little different between searches before, but it should certainly be fixed for place hold. Note: it only seems to work for cardnumber, not for userid. But I think this is ok, you are more likely to scan the card and expect a direct link than when searching for userid. Also userid might be more likely to be more uniqe. While sequential cardnumbers generated with autoMemberNum could lead to a long list of possible candidates quicky (especially if you started with 1).
Created attachment 134451 [details] [review] Bug 30622: Patron search when placing hold should redirect if cardnumber is entered When search a patron for placing a hold, if a cardnumber is entered we should pick the patron and use it, instead of display the table result. This was a regression caused by bug 30063. Test plan: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database Signed-off-by: David Nind <david@davidnind.com>
Working on this now.
Created attachment 134681 [details] [review] Bug 30622: Patron search when placing hold should redirect if cardnumber is entered When search a patron for placing a hold, if a cardnumber is entered we should pick the patron and use it, instead of display the table result. This was a regression caused by bug 30063. Test plan: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]