This was found while testing bug 30514. To test: - Edit any patron - Change the date of birth, verify: - Hint: (MM/DD/YYYY) - Adding a date, it displays in this format in the input field - Change Dateformat system prefernce to DD.MM.YYYY - Edit the patron again, Verify: - Hint: (TT.MM.YYYY) - Adding/updating the date it still shows in the previous format - Do a restart_all or equivalent on your test environment - Verify the date now has the correct format when edited A system preference change should take immediate effect. There should be no need to restart anything.
There is a bad space there: var dateformat_pref = "[% Koha.Preference('dateformat ') | html %]";
*** Bug 30711 has been marked as a duplicate of this bug. ***
Created attachment 134739 [details] [review] Bug 30706: Fix space in check for dateformat preference This patch fixes the calendar.inc includes in both staff and OPAC in order to remove a typo: An extra space in the check for the "dateformat" system preference. The result of this error is that changes to the dateformat system preference will not be correctly applied to Koha without a restart. To reproduce the problem start the process of creating a new patron. - In the date of birth field, select a date. The format of the date inserted should match your current dateformat system preference. - Go to Administration -> System preferences and update dateformat to something different. - Go back to the patron creation form (refresh it if necessary). - The hint under the Date of birth field will match your updated system preference, but when you pick a date using the calendar widget it will still be formatted according to the old value of dateformat. To test the fix, apply the patch and run through the same steps above. A change the dateformat preference should be immediately reflected in the functionality of the calendar widget.
Created attachment 134752 [details] [review] Bug 30706: Fix space in check for dateformat preference This patch fixes the calendar.inc includes in both staff and OPAC in order to remove a typo: An extra space in the check for the "dateformat" system preference. The result of this error is that changes to the dateformat system preference will not be correctly applied to Koha without a restart. To reproduce the problem start the process of creating a new patron. - In the date of birth field, select a date. The format of the date inserted should match your current dateformat system preference. - Go to Administration -> System preferences and update dateformat to something different. - Go back to the patron creation form (refresh it if necessary). - The hint under the Date of birth field will match your updated system preference, but when you pick a date using the calendar widget it will still be formatted according to the old value of dateformat. To test the fix, apply the patch and run through the same steps above. A change the dateformat preference should be immediately reflected in the functionality of the calendar widget. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 134770 [details] [review] Bug 30706: Fix space in check for dateformat preference This patch fixes the calendar.inc includes in both staff and OPAC in order to remove a typo: An extra space in the check for the "dateformat" system preference. The result of this error is that changes to the dateformat system preference will not be correctly applied to Koha without a restart. To reproduce the problem start the process of creating a new patron. - In the date of birth field, select a date. The format of the date inserted should match your current dateformat system preference. - Go to Administration -> System preferences and update dateformat to something different. - Go back to the patron creation form (refresh it if necessary). - The hint under the Date of birth field will match your updated system preference, but when you pick a date using the calendar widget it will still be formatted according to the old value of dateformat. To test the fix, apply the patch and run through the same steps above. A change the dateformat preference should be immediately reflected in the functionality of the calendar widget. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]