Bug 30762 - Terminology: Go to Staff client
Summary: Terminology: Go to Staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: krisw
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-05-15 09:09 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04


Attachments
Bug 30762: Terminology: Go to Staff client (1.91 KB, patch)
2022-07-07 22:58 UTC, Koha Training Catalyst
Details | Diff | Splinter Review
Bug 30762: Terminology: Go to Staff client (1.97 KB, patch)
2022-07-07 23:09 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 30762: Terminology: Go to Staff client (2.02 KB, patch)
2022-07-08 08:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-15 09:09:58 UTC
Found while translating:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt:73

Go to Staff client


This should be:

Go to staff interface
Comment 1 Koha Training Catalyst 2022-07-07 22:58:48 UTC
Created attachment 137337 [details] [review]
Bug 30762: Terminology: Go to Staff client

Test plan
Login to staff interface
Go to Administration. Search EnableExpiredPasswordReset. Enable this preference. Save.
Find your patron record and go to details.
In the ‘OPAC/Staff interface login’ section, set the Password expiration date to  the previous day. Save.
Open the OPAC in a new window.
Login to your account. It will fail. Click Reset your password.
Follow the process to add a new password.  Click update password.
See that it says ‘Go to staff interface’
Comment 2 Chris Cormack 2022-07-07 23:09:33 UTC
Created attachment 137340 [details] [review]
Bug 30762: Terminology: Go to Staff client

Test plan
Login to staff interface
Go to Administration. Search EnableExpiredPasswordReset. Enable this preference. Save.
Find your patron record and go to details.
In the ‘OPAC/Staff interface login’ section, set the Password expiration date to  the previous day. Save.
Open the OPAC in a new window.
Login to your account. It will fail. Click Reset your password.
Follow the process to add a new password.  Click update password.
See that it says ‘Go to staff interface’

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Works as advertised, still needs independent signoff
Comment 3 Katrin Fischer 2022-07-08 08:08:17 UTC
Created attachment 137373 [details] [review]
Bug 30762: Terminology: Go to Staff client

Test plan
Login to staff interface
Go to Administration. Search EnableExpiredPasswordReset. Enable this preference. Save.
Find your patron record and go to details.
In the ‘OPAC/Staff interface login’ section, set the Password expiration date to  the previous day. Save.
Open the OPAC in a new window.
Login to your account. It will fail. Click Reset your password.
Follow the process to add a new password.  Click update password.
See that it says ‘Go to staff interface’

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Katrin Fischer 2022-07-08 08:12:39 UTC
Thanks for the patch, going straight to PQA!
Comment 5 Tomás Cohen Arazi 2022-07-08 18:26:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-08-12 16:41:19 UTC
Backported to 22.05.x for 22.05.04
Comment 7 Arthur Suzuki 2022-08-16 12:45:18 UTC
Doesn't apply to 21.11.x