Bug 30763 - Typo: Barcode proceeds bibliographic data
Summary: Typo: Barcode proceeds bibliographic data
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Evan Giles
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-05-15 11:38 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04, 21.11.11
Circulation function:

Attachments
Bug 30763: fixes spelling of 'proceeds' (1.69 KB, patch)
2022-07-07 22:22 UTC, Koha Training Catalyst 		Details | Diff | Splinter Review
Bug 30763: fixes spelling of 'proceeds' (1.74 KB, patch)
2022-07-07 22:46 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 30763: fixes spelling of 'proceeds' (1.79 KB, patch)
2022-07-08 08:03 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-15 11:38:44 UTC 
I think proceeds should be preceeds here:

koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-layout.tt:6

Barcode proceeds bibliographic data
Comment 1 Katrin Fischer 2022-05-15 11:41:06 UTC 
Also here:
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-layout.tt:7

Bibliographic data proceeds barcode
Comment 2 Koha Training Catalyst 2022-07-07 22:22:14 UTC 
Created attachment 137335 [details] [review]
Bug 30763: fixes spelling of 'proceeds'

Test plan:
1. Login to the staff interface
2. go to tools
3. go to label creator
4. Click New -> Layout
5. Click the 'Choose layout type' dropdown
6. Notice the 'barcode proceeds biblio data' and 'biblio data proceeds
barcode'.  These are typos
7. Apply the patch and refresh the page
8 repeat step 5. Confirm 'proceeds' now correctly says 'precedes'

Sponsored by: Catalyst IT
Comment 3 Chris Cormack 2022-07-07 22:46:53 UTC 
Created attachment 137336 [details] [review]
Bug 30763: fixes spelling of 'proceeds'

Test plan:
1. Login to the staff interface
2. go to tools
3. go to label creator
4. Click New -> Layout
5. Click the 'Choose layout type' dropdown
6. Notice the 'barcode proceeds biblio data' and 'biblio data proceeds
barcode'.  These are typos
7. Apply the patch and refresh the page
8 repeat step 5. Confirm 'proceeds' now correctly says 'precedes'

Sponsored by: Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Tested and it works, still needs an independent sign off though
Comment 4 Katrin Fischer 2022-07-08 08:03:50 UTC 
Created attachment 137372 [details] [review]
Bug 30763: fixes spelling of 'proceeds'

Test plan:
1. Login to the staff interface
2. go to tools
3. go to label creator
4. Click New -> Layout
5. Click the 'Choose layout type' dropdown
6. Notice the 'barcode proceeds biblio data' and 'biblio data proceeds
barcode'.  These are typos
7. Apply the patch and refresh the page
8 repeat step 5. Confirm 'proceeds' now correctly says 'precedes'

Sponsored by: Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Katrin Fischer 2022-07-08 08:05:14 UTC 
Thx for the patch! As the fix is small I am going to move this straight to PQA.
Comment 6 Tomás Cohen Arazi (tcohen) 2022-07-08 18:26:25 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass (lukeg) 2022-08-12 16:39:13 UTC 
Backported to 22.05.x for 22.05.04
Comment 8 Arthur Suzuki 2022-08-16 12:42:52 UTC 
in 21.11.x for 21.11.11
Comment 9 Victor Grousset/tuxayo 2022-08-19 22:53:42 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.