Bug 30764 - Terminology: Cancelled reserve
Summary: Terminology: Cancelled reserve
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 30770
  Show dependency tree / graph
 
Reported: 2022-05-15 11:44 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04, 21.11.11
Circulation function:

Attachments
Bug 30764: replace "Cancelled reserve" with "Cancelled hold" (1.67 KB, patch)
2022-07-07 23:01 UTC, Koha Training Catalyst 		Details | Diff | Splinter Review
Bug 30764: replace "Cancelled reserve" with "Cancelled hold" (1.72 KB, patch)
2022-07-07 23:23 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 30764: replace "Cancelled reserve" with "Cancelled hold" (1.78 KB, patch)
2022-07-08 08:19 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-15 11:44:55 UTC 
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:136

Cancelled reserve

reserve should most likely be hold here.
Comment 1 Koha Training Catalyst 2022-07-07 23:01:09 UTC 
Created attachment 137339 [details] [review]
Bug 30764: replace "Cancelled reserve" with "Cancelled hold"

Test plan:
1. Inspect `koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt`, notice that on line 136 it says "Cancelled reserve"
2. Apply patch
3. Inspect the same line again and notice it now correctly says "Cancelled hold"
4. ???
5. Profit!

Sponsored-by: Catalyst IT
Comment 2 Chris Cormack 2022-07-07 23:23:09 UTC 
Created attachment 137345 [details] [review]
Bug 30764: replace "Cancelled reserve" with "Cancelled hold"

Test plan:
1. Inspect `koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt`, notice that on line 136 it says "Cancelled reserve"
2. Apply patch
3. Inspect the same line again and notice it now correctly says "Cancelled hold"
4. ???
5. Profit!

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Works as expected, needs inpdependent signoff
Comment 3 Katrin Fischer 2022-07-08 08:19:33 UTC 
Created attachment 137375 [details] [review]
Bug 30764: replace "Cancelled reserve" with "Cancelled hold"

Test plan:
1. Inspect `koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt`, notice that on line 136 it says "Cancelled reserve"
2. Apply patch
3. Inspect the same line again and notice it now correctly says "Cancelled hold"
4. ???
5. Profit!

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Katrin Fischer 2022-07-08 08:20:51 UTC 
Thanks for your patch, Filip! Passing QA!
Comment 5 Tomás Cohen Arazi (tcohen) 2022-07-08 18:15:23 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass (lukeg) 2022-08-12 16:12:22 UTC 
Backported to 22.05.x for 22.05.04
Comment 7 Arthur Suzuki 2022-08-16 12:22:06 UTC 
in 21.11.x for 21.11.11
Comment 8 Victor Grousset/tuxayo 2022-08-19 22:47:55 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.
Comment 9 Caroline Cyr La Rose 2023-05-09 18:21:03 UTC 
No occurrence of "Cancelled reserve" in the manual. I took the opportunity to change the few occurrences of reserve (meant as hold) to hold, but there wasn't much in the text.