Bug 30773 - Standardize spelling i-tive / Itiva
Summary: Standardize spelling i-tive / Itiva
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: krisw
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-05-16 09:09 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/679
Text to go in the release notes:
This standardizes the spelling used for i-tiva in the staff interface. When modifying notices (Tools > Notices & slips > [select any notice]) the section is now labelled 'Phone ( i-tiva )' - this is now consistent with the table heading used for Tools > Overdue notice/status triggers.
Version(s) released in:
22.11.00, 22.05.04, 21.11.11


Attachments
Bug 30773: Standardize spelling i-tive / Itiva (1.66 KB, patch)
2022-07-07 23:56 UTC, Koha Training Catalyst
Details | Diff | Splinter Review
Bug 30773: Standardize spelling i-tive / Itiva (1.72 KB, patch)
2022-07-08 00:05 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 30773: Standardize spelling i-tive / Itiva (1.77 KB, patch)
2022-07-08 04:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 30773: (follow-up) Remove spaces between brackets (1.40 KB, patch)
2022-07-08 06:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 30773: Standardize spelling i-tive / Itiva (1.82 KB, patch)
2022-07-08 08:36 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 30773: (follow-up) Remove spaces between brackets (1.46 KB, patch)
2022-07-08 08:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-16 09:09:58 UTC
Found while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:446
Phone ( Itiva )

vs.

koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt:98
Phone (i-tiva)
Comment 1 Koha Training Catalyst 2022-07-07 23:56:38 UTC
Created attachment 137354 [details] [review]
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.
Comment 2 Chris Cormack 2022-07-08 00:05:51 UTC
Created attachment 137355 [details] [review]
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Works as expected, needs independent sign off
Comment 3 David Nind 2022-07-08 04:54:22 UTC
Created attachment 137356 [details] [review]
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-07-08 05:02:43 UTC
Testing notes (using koha-testing-docker):

1. Different spelling is used for i-tiva (after enabling TalkingTechItivaPhoneNotification):
   - Tools > Notices & slips > [modify any notice]: spelling is 'Phone ( Itiva )' for the expandable section)
   - Tools > Overdue notice/status triggers: column heading is Phone (i-tiva)

2. Standardised on i-tiva, so, after the patch is applied, for any notice the expandable section is now labelled as 'Phone (i-tiva)'.

3. I think the spaces after and before the brackets could be removed, and it would be even more consistent. I'm not sure if this makes any difference for translation.
Comment 5 David Nind 2022-07-08 06:21:02 UTC
Created attachment 137365 [details] [review]
Bug 30773: (follow-up) Remove spaces between brackets

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2022-07-08 06:22:15 UTC
(In reply to David Nind from comment #4)
> 3. I think the spaces after and before the brackets could be removed, and it
> would be even more consistent. I'm not sure if this makes any difference for
> translation.

I've added a follow-up patch to remove the spaces between the brackets, will leave up to the QA Team to decide!
Comment 7 Katrin Fischer 2022-07-08 08:36:04 UTC
Created attachment 137382 [details] [review]
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 8 Katrin Fischer 2022-07-08 08:36:08 UTC
Created attachment 137383 [details] [review]
Bug 30773: (follow-up) Remove spaces between brackets

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 9 Tomás Cohen Arazi 2022-07-08 18:15:33 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Lucas Gass 2022-08-12 16:09:38 UTC
Backported to 22.05.x for 22.05.04
Comment 11 Arthur Suzuki 2022-08-16 12:19:35 UTC
in 21.11.x for 21.11.11
Comment 12 Victor Grousset/tuxayo 2022-08-19 22:47:26 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.