Found while translating: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:446 Phone ( Itiva ) vs. koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt:98 Phone (i-tiva)
Created attachment 137354 [details] [review] Bug 30773: Standardize spelling i-tive / Itiva In the Koha staff interface go to administration. Go to TalkingTechItivaPhoneNotification. Enable this preference. Save. Go to Tools > Overdue notice/status triggers Check that ‘Phone (i-tiva)’ is an option for notice types.
Created attachment 137355 [details] [review] Bug 30773: Standardize spelling i-tive / Itiva In the Koha staff interface go to administration. Go to TalkingTechItivaPhoneNotification. Enable this preference. Save. Go to Tools > Overdue notice/status triggers Check that ‘Phone (i-tiva)’ is an option for notice types. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as expected, needs independent sign off
Created attachment 137356 [details] [review] Bug 30773: Standardize spelling i-tive / Itiva In the Koha staff interface go to administration. Go to TalkingTechItivaPhoneNotification. Enable this preference. Save. Go to Tools > Overdue notice/status triggers Check that ‘Phone (i-tiva)’ is an option for notice types. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): 1. Different spelling is used for i-tiva (after enabling TalkingTechItivaPhoneNotification): - Tools > Notices & slips > [modify any notice]: spelling is 'Phone ( Itiva )' for the expandable section) - Tools > Overdue notice/status triggers: column heading is Phone (i-tiva) 2. Standardised on i-tiva, so, after the patch is applied, for any notice the expandable section is now labelled as 'Phone (i-tiva)'. 3. I think the spaces after and before the brackets could be removed, and it would be even more consistent. I'm not sure if this makes any difference for translation.
Created attachment 137365 [details] [review] Bug 30773: (follow-up) Remove spaces between brackets Signed-off-by: David Nind <david@davidnind.com>
(In reply to David Nind from comment #4) > 3. I think the spaces after and before the brackets could be removed, and it > would be even more consistent. I'm not sure if this makes any difference for > translation. I've added a follow-up patch to remove the spaces between the brackets, will leave up to the QA Team to decide!
Created attachment 137382 [details] [review] Bug 30773: Standardize spelling i-tive / Itiva In the Koha staff interface go to administration. Go to TalkingTechItivaPhoneNotification. Enable this preference. Save. Go to Tools > Overdue notice/status triggers Check that ‘Phone (i-tiva)’ is an option for notice types. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 137383 [details] [review] Bug 30773: (follow-up) Remove spaces between brackets Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.04
in 21.11.x for 21.11.11
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.