In the description of the system prefernce OpacAdvancedSearchTypes should be more lower case letters :) <em>Currently supported values</em>: Item types (<strong>itemtypes</strong>), Collection, (<strong>ccode</strong>) and Shelving Location (<strong>loc</strong>)...
Same applies to AdvancedSearchTypes
Created attachment 135086 [details] [review] Bug 30786: Fix capitalization in advanced search system preferences This fixes the capitalization in the descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. Test plan: 1. In the staff interface, search the system preferences for 'AdvancedSearch'. 2. Review the current descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. 3. Note that "..Shelving Location.." is used instead of "..Shelving location..". 4. Apply the patch. 5. Refresh the page. 6. Sentence case is now used for "Shelving location" in the descriptions (as per coding guideline HTML4: Upper and lower cases in strings). 7. Sign off. Signed-off-by: David Nind <david@davidnind.com>
Apologies Owen, I hadn't noticed that you had assigned this one to yourself!
(In reply to David Nind from comment #3) > Apologies Owen, I hadn't noticed that you had assigned this one to yourself! No problem at all--I was just the default assignee.
Created attachment 135111 [details] [review] Bug 30786: Fix capitalization in advanced search system preferences This fixes the capitalization in the descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. Test plan: 1. In the staff interface, search the system preferences for 'AdvancedSearch'. 2. Review the current descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. 3. Note that "..Shelving Location.." is used instead of "..Shelving location..". 4. Apply the patch. 5. Refresh the page. 6. Sentence case is now used for "Shelving location" in the descriptions (as per coding guideline HTML4: Upper and lower cases in strings). 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
All working well; signed off.
Created attachment 135449 [details] [review] Bug 30786: Fix capitalization in advanced search system preferences This fixes the capitalization in the descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. Test plan: 1. In the staff interface, search the system preferences for 'AdvancedSearch'. 2. Review the current descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. 3. Note that "..Shelving Location.." is used instead of "..Shelving location..". 4. Apply the patch. 5. Refresh the page. 6. Sentence case is now used for "Shelving location" in the descriptions (as per coding guideline HTML4: Upper and lower cases in strings). 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
pushed to 21.11.x for 21.11.11, thx!
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.