placerequest.pl contains an useless check "$type eq 'str8'" which doesn't do anything. This should be removed.
Created attachment 135257 [details] [review] Bug 30828: remove useless type parameter in placerequest.pl To test: 1) Grep for placerequest.pl in the source code and check that request.tt is the only place where the type parameter is passed.
Tested and signed off by Michal Urban
Created attachment 135283 [details] [review] Bug 30828: remove useless type parameter in placerequest.pl To test: 1) Grep for placerequest.pl in the source code and check that request.tt is the only place where the type parameter is passed. Signed-off-by: David Nind <david@davidnind.com>
Testing notes: 1. Before applying patch: git grep "$type eq 'str8'" 2. Should only find one occurrence in reserve/placerequest.pl 3 After applying patch, no occurences.
(In reply to Michal Urban from comment #3) > Tested and signed off by Michal Urban Hi Michal. Looks like we were both testing at the same time! Hopefully the QA Team can add your sign off to the patch. David
(In reply to David Nind from comment #6) > (In reply to Michal Urban from comment #3) > > Tested and signed off by Michal Urban > > Hi Michal. > > Looks like we were both testing at the same time! > > Hopefully the QA Team can add your sign off to the patch. > > David Haha what a coincidence. Thanks David, this was my first test so I wasn’t sure what to do but I’ll make sure to add test notes like you did next time. :)
Created attachment 135467 [details] [review] Bug 30828: Remove useless 'type' parameter in placerequest.pl To test: 1) Grep for placerequest.pl in the source code and check that request.tt is the only place where the type parameter is passed. Signed-off-by: David Nind <david@davidnind.com> JD amended patch: adjust commit title Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Funky historical weirdness...
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
thx, pushed to 21.11.x for 21.11.07
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.