Koha currently uses v1.19.1 of the jQuery Validation plugin which was released in 2019. We should upgrade to the latest version, which at the time I'm filing the bug is 1.19.4. Updates to the plugin have been made to improve compatibility with the latest version of jQuery.
Created attachment 135420 [details] [review] Bug 30859: Upgrade jQuery Validation plugin from v1.19.1 This patch updates the jQuery Validation plugin in both the OPAC and staff interface. This upgrade brings the plugin to the current latest version (1.19.4) which includes compatibility fixes for the latest version of jQuery. To test, apply the patch and test various forms in the OPAC and staff interface to confirm that validation is still working correctly. In the OPAC: - Patron self-registration: Required fields, password match and complexity. Test also the "Forgot password" and "Change password" interfaces. In the staff interface, for example: - Patrons -> Patron password change: Required fields, password match and complexity. - Administration -> Patron categories -> New category: - Required fields - One or the other enrollment period inputs - Digits required in password expiration, age required, upper age limit - Numbers required in enrollment and hold fee. - Administration -> Budgets -> New budget: - Required fields - End date must be after start date - Administration -> Cities & towns: Required fields
Created attachment 135443 [details] [review] Bug 30859: Upgrade jQuery Validation plugin from v1.19.1 This patch updates the jQuery Validation plugin in both the OPAC and staff interface. This upgrade brings the plugin to the current latest version (1.19.4) which includes compatibility fixes for the latest version of jQuery. To test, apply the patch and test various forms in the OPAC and staff interface to confirm that validation is still working correctly. In the OPAC: - Patron self-registration: Required fields, password match and complexity. Test also the "Forgot password" and "Change password" interfaces. In the staff interface, for example: - Patrons -> Patron password change: Required fields, password match and complexity. - Administration -> Patron categories -> New category: - Required fields - One or the other enrollment period inputs - Digits required in password expiration, age required, upper age limit - Numbers required in enrollment and hold fee. - Administration -> Budgets -> New budget: - Required fields - End date must be after start date - Administration -> Cities & towns: Required fields Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but noted these things - these are the same behaviour as in current master: - New patron category: password expiration field is not validated - can enter anything, if not valid is blank on edit (have logged as bug 30864). - Patron changing their password from their account (change your password): this form (as well as the forgotten password form) work "differently", with any error messages shown in a text block above the form instead of highlight errors in red. This is the current behaviour, and things validate as expected. Other testing notes (koha-testing-docker): to enable forgotten password recovery, the system preference is OpacResetPassword.
Created attachment 136162 [details] [review] Bug 30859: Upgrade jQuery Validation plugin from v1.19.1 This patch updates the jQuery Validation plugin in both the OPAC and staff interface. This upgrade brings the plugin to the current latest version (1.19.4) which includes compatibility fixes for the latest version of jQuery. To test, apply the patch and test various forms in the OPAC and staff interface to confirm that validation is still working correctly. In the OPAC: - Patron self-registration: Required fields, password match and complexity. Test also the "Forgot password" and "Change password" interfaces. In the staff interface, for example: - Patrons -> Patron password change: Required fields, password match and complexity. - Administration -> Patron categories -> New category: - Required fields - One or the other enrollment period inputs - Digits required in password expiration, age required, upper age limit - Numbers required in enrollment and hold fee. - Administration -> Budgets -> New budget: - Required fields - End date must be after start date - Administration -> Cities & towns: Required fields Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!
Enhancement will not be backported to 22.05.x series unless requested
No update to Koha manual needed.