At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.
In it's most basic form, this should just be exposed as a delete button for any rota's that have no items attached. Thinking more widely, it would be nice to allow deletion regardless and give options to disassociate items from the rota at deletion time including setting where those items should end up. From memory, non-cyclical rota's don't clean up after themselves either.. it might be nice to have the option to remove the item to rota link once at item hits it's final destination.
Confirmed on master with my superlibrarian user: * Enable StockRotation system preference * Tools > Stock rotation > New rota * Enter Name, save. * There is no delete button visible.
Created attachment 143144 [details] [review] Add delete action to stock rotation rotas To test: 1) Enable StockRotation system preference 2) Tools > Stock rotation > New rota 3) Enter Name, save 4) Verify "Delete" button shows on the right 5) Click "Delete" -> Confirm "Yes" 6) Repeat steps 1-3 and click "Manage"->"Stages" 7) Add a new stage, enter Library and Duration, click "Save" 8) Return to rotas, click "Manage"->"Items" 9) Add item, enter barcode, click "Save" (optional: add more than 1 item) 10) Click "return to rotas" and press "Delete" 11) Verify the warning now shows, because items are attached, with the attached items count 12) Click "Delete" -> Deletion is successful
Created attachment 143148 [details] [review] Add delete action to stock rotation rotas To test: 1) Enable StockRotation system preference 2) Tools > Stock rotation > New rota 3) Enter Name, save 4) Verify "Delete" button shows on the right 5) Click "Delete" -> Confirm "Yes" 6) Repeat steps 1-3 and click "Manage"->"Stages" 7) Add a new stage, enter Library and Duration, click "Save" 8) Return to rotas, click "Manage"->"Items" 9) Add item, enter barcode, click "Save" (optional: add more than 1 item) 10) Click "return to rotas" and press "Delete" 11) Verify the warning now shows, because items are attached, with the attached items count 12) Click "Delete" -> Deletion is successful
The patch no longer applies 8-(.. root@kohadevbox:koha(bz30869)$ git bz apply 30869 Bug 30869 - Stock rotation rotas cannot be deleted 143148 - Add delete action to stock rotation rotas Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30869: Stock rotation rotas cannot be deleted Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 30869: Stock rotation rotas cannot be deleted
Also, the QA Team will require the patch to be formatted according to the guidelines at https://wiki.koha-community.org/wiki/Commit_messages
Created attachment 145275 [details] [review] Bug 30869: Stock rotation rotas cannot be deleted 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe
Hi David. Can you please check now that the patch applies and/or if the test plan goes accordingly. Thank you!
(In reply to Pedro Amorim from comment #8) > Can you please check now that the patch applies and/or if the test plan goes > accordingly. Thanks Pedro! The patch now applies, sign off shortly. David
Created attachment 145323 [details] [review] Bug 30869: Stock rotation rotas cannot be deleted 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145353 [details] [review] Bug 30869: Stock rotation rotas cannot be deleted 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe Signed-off-by: David Nind <david@davidnind.com>
Fixed commit author, had originally been submitted as John Doe.
Created attachment 147251 [details] [review] Bug 30869: Add the ability to delete stock rotation rotas 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe Signed-off-by: David Nind <david@davidnind.com> JD Amended patch: * Fix QA failures FAIL forbidden patterns forbidden pattern: tab char (line 150) forbidden pattern: tab char (line 151) * Adjust commit message to describe what the patch does Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This script needs a bit of cleanup, there is no error handling and we should not need the redirects.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Does not apply clean to 22.05.x, no backport.
Koha manual updated.