Created attachment 135493 [details] [review] Bug 30871: Add/expand title text for LDR/06 and 008 Type of material This patch simply adds title elements or clarifies existing title elements to indicate how default values are chosen To test: 1 - Create new record in default editor 2 - Open leader helper, hover over "6-Type of record" and the dropdown 3 - Confirm notes make sense 4 - Open 008 helper 5 - Hover over 'Type of Material' and dropdown 6 - Confirm notes make sense
Created attachment 135494 [details] [review] Bug 30871: Add notes in advanced cataloging editor This is the same as preevious patch, but for advanced cataloging editor To test: 1 - Enable EnableAdvancedCatalogingEditor 2 - Create a new record in advanced edtior 3 - Hover over leader6 and 008 type 4 - Confirm notes are useful
Created attachment 135517 [details] [review] Bug 30871: Add/expand title text for LDR/06 and 008 Type of material This patch simply adds title elements or clarifies existing title elements to indicate how default values are chosen To test: 1 - Create new record in default editor 2 - Open leader helper, hover over "6-Type of record" and the dropdown 3 - Confirm notes make sense 4 - Open 008 helper 5 - Hover over 'Type of Material' and dropdown 6 - Confirm notes make sense Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135518 [details] [review] Bug 30871: Add notes in advanced cataloging editor This is the same as preevious patch, but for advanced cataloging editor To test: 1 - Enable EnableAdvancedCatalogingEditor 2 - Create a new record in advanced edtior 3 - Hover over leader6 and 008 type 4 - Confirm notes are useful Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): 1. I amended the second patch for the advanced editor to add a full stop at the end of the sentence ("..controlled by Leader/06.") - maybe I should have done as a follow-up? 2. I changed the assignee to Nick. A nice clarification and improvement!
Created attachment 136147 [details] [review] Bug 30871: Add/expand title text for LDR/06 and 008 Type of material This patch simply adds title elements or clarifies existing title elements to indicate how default values are chosen To test: 1 - Create new record in default editor 2 - Open leader helper, hover over "6-Type of record" and the dropdown 3 - Confirm notes make sense 4 - Open 008 helper 5 - Hover over 'Type of Material' and dropdown 6 - Confirm notes make sense Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 136148 [details] [review] Bug 30871: Add notes in advanced cataloging editor This is the same as preevious patch, but for advanced cataloging editor To test: 1 - Enable EnableAdvancedCatalogingEditor 2 - Create a new record in advanced edtior 3 - Hover over leader6 and 008 type 4 - Confirm notes are useful Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple improvement, passing qa
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.04. Added a tiny follow-up to fix a forbidden character FAIL
backported to 21.11.x for 21.11.11
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.