To reproduce: - Make sure you have the ILL module set up, with at least one active request - Click on "Manage request" for a request You are now on a page like /cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1766 The breadcrumbs are "Home > ILL requests" and "ILL requests" is a link to the same page you are on. I would expect the breadcrumbs to be something like "Home > ILL requests > Manage request number 1766", with "ILL requests" being a link to /cgi-bin/koha/ill/ill-requests.pl (same as the "List requests" button).
*** Bug 31494 has been marked as a duplicate of this bug. ***
Created attachment 140037 [details] [review] Bug 30890: Fixed ILL breadcrumb Added correct breadrumb depth when managing requests. 1. Viewing a request on a ILL request page 2. Making sure the breadcrumb has three depths and the manage requests has the correct request id
- [% ELSIF query_type == 'status' %] + [% ELSIF query_type == 'illview' %] Is the "status" query_type not used for anything?
(In reply to Owen Leonard from comment #3) > - [% ELSIF query_type == 'status' %] > + [% ELSIF query_type == 'illview' %] > > Is the "status" query_type not used for anything? It's a good question.. as far as I can tell from the controller query_type will never be returned with a value of 'status'. I tried digging through the git logs to see when it was introduced or changed, but it appears to have never been returned going as far back as the original introduction of ILL into core Koha.
Created attachment 140277 [details] [review] Bug 30890: Fixed ILL breadcrumb Added correct breadrumb depth when managing requests. 1. Viewing a request on a ILL request page 2. Making sure the breadcrumb has three depths and the manage requests has the correct request id Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 140280 [details] [review] Bug 30890: Fixed ILL breadcrumb Added correct breadrumb depth when managing requests. 1. Viewing a request on a ILL request page 2. Making sure the breadcrumb has three depths and the manage requests has the correct request id Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
applied to 21.11 for 21.11.14
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.