Bug 30893 - Typo: update_patrons_category.pl fine(s)
Summary: Typo: update_patrons_category.pl fine(s)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: 21.05
Hardware: All All
: P5 - low minor
Assignee: Nick Clemens (kidclamp)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-02 17:03 UTC by Evelyn Hartline
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the help text for the update patrons category cronjob script (misc/cronjobs/update_patrons_category.pl). It changes the full option names and associated information for -fo (--fineover to --finesover) and -fu (--fineunder to --finesunder), as well as some minor formatting and text tidy ups.
Version(s) released in:
22.11.00, 22.05.01, 21.11.07
Circulation function:

Attachments
Bug 30893: Fix documentation in update_patrons_category.pl (1.80 KB, patch)
2022-06-03 11:36 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 30893: Fix documentation in update_patrons_category.pl (2.71 KB, patch)
2022-06-04 01:07 UTC, David Nind 		Details | Diff | Splinter Review
Bug 30893: Fix documentation in update_patrons_category.pl (2.77 KB, patch)
2022-06-06 10:57 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evelyn Hartline 2022-06-02 17:03:50 UTC 
in the SYNOPSIS and OPTIONS portions of update_patrons_category.pl, the options fineover and fineunder do not match the GetOptions finesover and finesunder. The shortened versions can be used, but the plural/not plural should be fixed. 

 -fo=X --fineover=X       update if fines over  X amount
 -fu=X --fineunder=X      update if fines under X amount

vs

 'fo|finesover=s'  => \$fine_min,
 'fu|finesunder=s' => \$fine_max,
Comment 1 Nick Clemens (kidclamp) 2022-06-03 11:36:07 UTC 
Created attachment 135677 [details] [review]
Bug 30893: Fix documentation in update_patrons_category.pl
Comment 2 David Nind 2022-06-04 01:07:29 UTC 
Created attachment 135698 [details] [review]
Bug 30893: Fix documentation in update_patrons_category.pl

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-06-04 01:12:41 UTC 
I amended the patch to fix a couple of minor things:

- -fo and -fu: extra spaces before update (so they line up with the other items), removed space for -fo between "..over X.."

- -too_young: removed extra space between age and current

- --from and --to: changed to sentence case so now "*Required* Defines.." instead of "*required* defines.."
Comment 4 Katrin Fischer 2022-06-06 10:57:26 UTC 
Created attachment 135720 [details] [review]
Bug 30893: Fix documentation in update_patrons_category.pl

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-06-06 14:38:46 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass (lukeg) 2022-06-15 16:29:10 UTC 
Pushed to 22.05.x for 22.05.01
Comment 7 Arthur Suzuki 2022-06-21 13:57:01 UTC 
thx! pushed to 21.11.x for 21.11.07
Comment 8 Victor Grousset/tuxayo 2022-06-26 00:12:35 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.