To recreate: 1. Go to course resereves, add a course. 2. Go to the course and add a reserve at the bib-level ( use biblionumber of a bibliographic record ) 3. Notice the normal DataTable controls are missing and if you look at the browser console you will see an error: Uncaught TypeError: i is undefined
This is due to the way DataTables supports colspans.
Created attachment 137413 [details] [review] Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve This patch removes the colspan from biblio-level course reserves rows in favor of adding a style to the message's container allowing it to overflow across table cells. To test, apply the patch and go to course reserves. 1. If necessary, add a new course. 2. View the details of the course and add a reserve using the biblionumber option to add the reserve at the bibliographic level. 3. Add a notes if you want, then click "Save." 4. Return to the course detail view. 5. In the table of reserves your biblio-level reserve should have a message starting in the "Barcode" column and overflowing across other item information columns, "Item information is not available for record-level course reserve." 6. Try adding multiple item-level and biblio-level reserves to the same course to confirm that the information displays well in those cases.
Created attachment 137426 [details] [review] Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve This patch removes the colspan from biblio-level course reserves rows in favor of adding a style to the message's container allowing it to overflow across table cells. To test, apply the patch and go to course reserves. 1. If necessary, add a new course. 2. View the details of the course and add a reserve using the biblionumber option to add the reserve at the bibliographic level. 3. Add a notes if you want, then click "Save." 4. Return to the course detail view. 5. In the table of reserves your biblio-level reserve should have a message starting in the "Barcode" column and overflowing across other item information columns, "Item information is not available for record-level course reserve." 6. Try adding multiple item-level and biblio-level reserves to the same course to confirm that the information displays well in those cases. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Thanks a lot, Owen!
Created attachment 137427 [details] [review] Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve This patch removes the colspan from biblio-level course reserves rows in favor of adding a style to the message's container allowing it to overflow across table cells. To test, apply the patch and go to course reserves. 1. If necessary, add a new course. 2. View the details of the course and add a reserve using the biblionumber option to add the reserve at the bibliographic level. 3. Add a notes if you want, then click "Save." 4. Return to the course detail view. 5. In the table of reserves your biblio-level reserve should have a message starting in the "Barcode" column and overflowing across other item information columns, "Item information is not available for record-level course reserve." 6. Try adding multiple item-level and biblio-level reserves to the same course to confirm that the information displays well in those cases. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Working as expected.. Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.04
applied to 21.11.x for 21.11.11
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.
(In reply to Victor Grousset/tuxayo from comment #10) > Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. > > Nothing to document, marking resolved. Dependency is not in 21.11.