Bug 30922 - Make the "Relative's checkouts" table configurable by the table settings
Summary: Make the "Relative's checkouts" table configurable by the table settings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Shi Yao Wang
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-07 19:13 UTC by Marie-Luce Laflamme
Modified: 2023-06-08 22:26 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings (6.24 KB, patch)
2022-07-06 15:07 UTC, Shi Yao Wang
Details | Diff | Splinter Review
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings (6.41 KB, patch)
2022-07-07 17:56 UTC, Shi Yao Wang
Details | Diff | Splinter Review
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings (6.46 KB, patch)
2022-07-07 20:37 UTC, David Nind
Details | Diff | Splinter Review
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings (6.52 KB, patch)
2022-08-13 07:33 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marie-Luce Laflamme 2022-06-07 19:13:39 UTC
the Patron > moremember > issues-table are not applied correctly. If you hide columns, hidden columns are still displayed in the relative's checkouts.

1. Go to admin > Table settings > Patron > moremember > issues-table
2. Hide few columns  (e.g. record_type)
3. Find a patron account
4. Checkout an item
5. Add a guarantee to this account
6. Check the "relatives' checkouts" tab
All the columns are still visible.
Comment 1 Jonathan Druart 2022-06-08 10:26:17 UTC
It's not that is not working, it's not the same table. The "relative's checkouts" table is not part of the table settings yet.
Comment 2 Shi Yao Wang 2022-07-06 15:07:00 UTC
Created attachment 137218 [details] [review]
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are hidden
Comment 3 David Nind 2022-07-07 09:45:12 UTC
A couple of comments from testing:

1. This works for the relatives' checkouts tab on the check out and details sections of the patron's page.

2. Normally, when the table settings are configurable, there is a 'Columns' button above the actual table that lets you toggle the columns on and off. I'm not seeing it for this table. For an example, check out something to the guarantor and you should see what I mean.
Comment 4 Shi Yao Wang 2022-07-07 17:56:56 UTC
Created attachment 137332 [details] [review]
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are hidden
6- Also notice the "Columns" and "Export" buttons that should work as
intended
Comment 5 David Nind 2022-07-07 20:37:50 UTC
Created attachment 137334 [details] [review]
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are hidden
6- Also notice the "Columns" and "Export" buttons that should work as
intended

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Fridolin Somers 2022-08-13 07:26:35 UTC
I've compared in colum_settings.yaml 'issues-table' and 'relatives-issues-table'.
We see that 'homebranch' is missing from relatives issues table.
But it is also missing in checkouts.js so it is for another bug report.
Comment 7 Fridolin Somers 2022-08-13 07:29:20 UTC
I imagine no one would like to hide the "patron" column but we can keep it configurable.
Comment 8 Fridolin Somers 2022-08-13 07:33:54 UTC
Created attachment 139089 [details] [review]
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are hidden
6- Also notice the "Columns" and "Export" buttons that should work as
intended

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Comment 9 Tomás Cohen Arazi 2022-08-16 13:53:49 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Lucas Gass 2022-10-03 22:12:26 UTC
Enhancment will not be backported to 22.05.x series