I've seen a couple of bugs on this and they're all 'Resolved' but I still see the problem. Maybe it's not the exact same thing... So I'm creating this in case. Someone else can test and tell me if I'm crazy or not. When a biblio has more than one hold (record-level), the 'First patron' column on the 'Holds to pull' report is not showing the actual first patron, but the last in the line. I tried it on a bywater sandbox, just in case it was my installation that was the problem, and it does the same thing. To test : 1) Place a record-level hold on a biblio with an available item 2) Check the Holds to pull page (circ/pendingreserves.pl) --> The biblio should appear in the list and the patron should appear in the 'First patron' column 3) Place a second record-level hold on the same biblio 4) Go back to the Holds to pull page --> The biblio is still there, but the patron in the 'First patron' column is the second patron 5) Place a third record-level hold on the same biblio 6) Go back to the Holds to pull page --> The biblio is still there, but the patron in the 'First patron' column is the third patron Other bugs I found that talk about this: Bug 24488 (Closed fixed), Bug 30337 (pushed to master)
Created attachment 135904 [details] List of holds for the title
Created attachment 135905 [details] Holds to pull list shows third patron
I added some screenshots of the sandbox. Just in case it's relevant... In about, it says I'm at version 22.06.00.001 The last commit in the git log is commit d9e8a0e9d23a62e64a1b67e96e0dd2de9613e2ab Author: Tomás Cohen Arazi <tomascohen@theke.io> Date: Tue Jun 7 09:36:31 2022 -0300 Bug 13614: Compiled CSS Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> In the git log of the sandbox, I see the patch for Bug 30337 but not the one for bug 24488 (probably because it's too old, I'm not sure how many commits that git log shows)
Created attachment 136741 [details] [review] Bug 30935: Holds to pull shows wrong first patron When different patrons have item level holds on the same item, Holds to pull shows wrong first patron. Test plan: 1) Place a record-level hold on a biblio with an available item 2) Check the Holds to pull page (circ/pendingreserves.pl) --> The biblio should appear in the list and the patron should appear in the 'First patron' column 3) Place a second record-level hold on the same biblio 4) Go back to the Holds to pull page --> The biblio is still there, but the patron in the 'First patron' column is the second patron 5) Place a third record-level hold on the same biblio 6) Go back to the Holds to pull page --> The biblio is still there, but the patron in the 'First patron' column is the third patron 7) Apply the patch 8) Go back to the Holds to pull page --> The biblio is still there and the patron in the 'First patron' column is the first patron
Created attachment 137611 [details] [review] Bug 30935: Holds to pull shows wrong first patron When different patrons have item level holds on the same item, Holds to pull shows wrong first patron. Test plan: 1) Place a record-level hold on a biblio with an available item 2) Check the Holds to pull page (circ/pendingreserves.pl) --> The biblio should appear in the list and the patron should appear in the 'First patron' column 3) Place a second record-level hold on the same biblio 4) Go back to the Holds to pull page --> The biblio is still there, but the patron in the 'First patron' column is the second patron 5) Place a third record-level hold on the same biblio 6) Go back to the Holds to pull page --> The biblio is still there, but the patron in the 'First patron' column is the third patron 7) Apply the patch 8) Go back to the Holds to pull page --> The biblio is still there and the patron in the 'First patron' column is the first patron Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described; thanks for the patch!
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
*** Bug 31467 has been marked as a duplicate of this bug. ***
thx pushed to 21.11.x for 21.11.12
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.
*** Bug 31600 has been marked as a duplicate of this bug. ***
Can't wait to see this fix implemented. I'm so glad that it appears to have been solved. Thanks, Steve