Bug 30936 - Reindent authority detail template in staff interface
Summary: Reindent authority detail template in staff interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-09 18:25 UTC by Owen Leonard
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04


Attachments
Bug 30936: Reindent authority detail template (9.48 KB, patch)
2022-06-09 18:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30936: (follow-up) Add markup comments (2.98 KB, patch)
2022-06-09 18:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30936: Reindent authority detail template (9.53 KB, patch)
2022-06-17 22:14 UTC, David Nind
Details | Diff | Splinter Review
Bug 30936: (follow-up) Add markup comments (3.02 KB, patch)
2022-06-17 22:14 UTC, David Nind
Details | Diff | Splinter Review
Bug 30936: Reindent authority detail template (9.59 KB, patch)
2022-06-17 22:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 30936: (follow-up) Add markup comments (3.08 KB, patch)
2022-06-17 22:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-06-09 18:25:13 UTC
I propose to reformat the authority detail template in the staff interface (authorities/detail.tt) so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2022-06-09 18:32:30 UTC
Created attachment 135911 [details] [review]
Bug 30936: Reindent authority detail template

This patch updates the authority detail template so that indentation is
consistent.

To test, apply the patch and go to Authorities.

- Locate an authority record and view the detail page.
- Everything should look correct, with working numbered tabs.
- If the AuthDisplayHierarchy preference is enabled, you should see a
  collapsible tree of elements in the authority hierarchy.
Comment 2 Owen Leonard 2022-06-09 18:32:34 UTC
Created attachment 135912 [details] [review]
Bug 30936: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 David Nind 2022-06-17 22:14:19 UTC
Created attachment 136315 [details] [review]
Bug 30936: Reindent authority detail template

This patch updates the authority detail template so that indentation is
consistent.

To test, apply the patch and go to Authorities.

- Locate an authority record and view the detail page.
- Everything should look correct, with working numbered tabs.
- If the AuthDisplayHierarchy preference is enabled, you should see a
  collapsible tree of elements in the authority hierarchy.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-06-17 22:14:23 UTC
Created attachment 136316 [details] [review]
Bug 30936: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2022-06-17 22:30:31 UTC
Created attachment 136318 [details] [review]
Bug 30936: Reindent authority detail template

This patch updates the authority detail template so that indentation is
consistent.

To test, apply the patch and go to Authorities.

- Locate an authority record and view the detail page.
- Everything should look correct, with working numbered tabs.
- If the AuthDisplayHierarchy preference is enabled, you should see a
  collapsible tree of elements in the authority hierarchy.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2022-06-17 22:30:35 UTC
Created attachment 136319 [details] [review]
Bug 30936: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2022-06-25 14:27:03 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-07-29 16:21:45 UTC
Backported to 22.05.x for 22.05.04
Comment 9 Arthur Suzuki 2022-08-11 12:46:34 UTC
conflicts when trying to apply to 21.11.x. please provide backport if needed.