Created attachment 135937 [details] [review] Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf
Created attachment 136000 [details] [review] Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): 1. I didn't check the "Category of instrument or voice" fully against https://www.iflastandards.info/unimarc/terms/mop 2. Everything else seemed to work as expected. This may require someone who is ore familiar with UNIMARC to sign off as well.
Created attachment 139478 [details] [review] Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 139483 [details] [review] Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 139484 [details] [review] Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 139488 [details] [review] Bug 30941: (QA follow-up) Import methods explicitly By explicitly importing the Koha::I18N methods, I get rid of this error: kohadev-koha@kohadevbox:/kohadevbox/koha$ qa -c 2 --run-tests testing 2 commit(s) (applied to 9b2bf04 '09 Bug 30507: Value builder for field') Processing files before patches |========================>| 12 / 12 (100.00%) An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::I18N': current merge results [ Koha::I18N, ] merging failed on 'Exporter' at /kohadevbox/qa-test-tools/koha-qa.pl line 112. This happens because the Koha::I18N library is exporting all its methods explicitly and, by design, the __ methods used in value builders cannot determine which of the imported methods to use i.e. if Koha::I118N::__ or Koha::CodeList::Unimarc::MediumOfPerformance:__ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Created attachment 139497 [details] [review] Bug 30941: (QA follow-up) Only export what is needed Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Enhancement will not be in 22.05.x