Bug 30941 - Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
Summary: Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-10 12:07 UTC by Julian Maurice
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Large patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds value builders for UNIMARC 146$b, $c, $d, $e, and $f.
Version(s) released in:
22.11.00


Attachments
Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) (80.45 KB, patch)
2022-06-10 13:29 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) (80.50 KB, patch)
2022-06-13 09:31 UTC, David Nind
Details | Diff | Splinter Review
Bug 30941: (QA follow-up) Add exec flag to scripts (1.67 KB, patch)
2022-08-19 11:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) (80.55 KB, patch)
2022-08-19 11:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30941: (QA follow-up) Add exec flag to scripts (1.67 KB, patch)
2022-08-19 11:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30941: (QA follow-up) Import methods explicitly (1.55 KB, patch)
2022-08-19 12:54 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 30941: (QA follow-up) Only export what is needed (1.13 KB, patch)
2022-08-19 14:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2022-06-10 12:07:42 UTC

    
Comment 1 Julian Maurice 2022-06-10 13:29:41 UTC
Created attachment 135937 [details] [review]
Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC)

Test plan:
1. Configure the default MARC framework to use those value builders:
   - unimarc_field_146b for 146$b
   - unimarc_field_146c for 146$c
   - unimarc_field_146d for 146$d
   - unimarc_field_146e for 146$e
   - unimarc_field_146f for 146$f
2. Verify that they all work correctly according to
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf
Comment 2 David Nind 2022-06-13 09:31:05 UTC
Created attachment 136000 [details] [review]
Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC)

Test plan:
1. Configure the default MARC framework to use those value builders:
   - unimarc_field_146b for 146$b
   - unimarc_field_146c for 146$c
   - unimarc_field_146d for 146$d
   - unimarc_field_146e for 146$e
   - unimarc_field_146f for 146$f
2. Verify that they all work correctly according to
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-06-13 09:34:52 UTC
Testing notes (using koha-testing-docker):

1. I didn't check the "Category of instrument or voice" fully against https://www.iflastandards.info/unimarc/terms/mop

2. Everything else seemed to work as expected.

This may require someone who is ore familiar with UNIMARC to sign off as well.
Comment 4 Kyle M Hall 2022-08-19 11:26:25 UTC
Created attachment 139478 [details] [review]
Bug 30941: (QA follow-up) Add exec flag to scripts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall 2022-08-19 11:52:27 UTC
Created attachment 139483 [details] [review]
Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC)

Test plan:
1. Configure the default MARC framework to use those value builders:
   - unimarc_field_146b for 146$b
   - unimarc_field_146c for 146$c
   - unimarc_field_146d for 146$d
   - unimarc_field_146e for 146$e
   - unimarc_field_146f for 146$f
2. Verify that they all work correctly according to
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2022-08-19 11:52:36 UTC
Created attachment 139484 [details] [review]
Bug 30941: (QA follow-up) Add exec flag to scripts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2022-08-19 12:54:29 UTC
Created attachment 139488 [details] [review]
Bug 30941: (QA follow-up) Import methods explicitly

By explicitly importing the Koha::I18N methods, I get rid of this error:

kohadev-koha@kohadevbox:/kohadevbox/koha$ qa -c 2 --run-tests
testing 2 commit(s) (applied to 9b2bf04 '09 Bug 30507: Value builder for field')

Processing files before patches
|========================>| 12 / 12 (100.00%)

An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::I18N':
	current merge results [
		Koha::I18N,
	]
	merging failed on 'Exporter' at /kohadevbox/qa-test-tools/koha-qa.pl line 112.

This happens because the Koha::I18N library is exporting all its methods
explicitly and, by design, the __ methods used in value builders cannot
determine which of the imported methods to use i.e. if Koha::I118N::__
or Koha::CodeList::Unimarc::MediumOfPerformance:__

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi 2022-08-19 12:58:06 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Tomás Cohen Arazi 2022-08-19 14:09:50 UTC
Created attachment 139497 [details] [review]
Bug 30941: (QA follow-up) Only export what is needed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 10 Lucas Gass 2022-10-14 19:16:07 UTC
Enhancement will not be in 22.05.x