We're setting up MARC Overlay Rules in 21.11.05. When defining the rules, we aren't able to make the filter Z39.50 work. A colleague checked the code and reports that line 876 in cataloguing/addbiblio.pl sets the source to z39.50. The source value should be z3950 to match the filter.
Hi Björn, that's a great hint already - does your coworker want to provide a patch for this? We are happy to help with the steps!
(In reply to Katrin Fischer from comment #1) > Hi Björn, that's a great hint already - does your coworker want to provide a > patch for this? We are happy to help with the steps! Hi, we've asked our administrators to check if this could be a solution. If it is, we'll ask them if they can provide a patch.
We've now edited the code as suggested, but it didn't work. All fields are protected except when replacing record via Z39.50/SRU search; if I replace the record this way, the fields that I've listed as protected are also edited.
We found out that the protection applies only after you have saved the imported record, which is kind of confusing when looking the record on the editor. Fixing the z3950 syntax works but I think that there should be done something so the protected fields appear to the editor. If you have required fields then those have to be filled before save and the new values don't even apply because of the protection.
Created attachment 138248 [details] [review] Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy
Attempted to apply patch, but terminal returned : error: Failed to merge in the changes.
Created attachment 139014 [details] [review] Record Overlay Rules - can't use Z39.50 filter I updated the patch, please try again.
Created attachment 140004 [details] [review] Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
It looks like the * (all) case might not be covered properly yet: My overlay rules: * source * 245 Protect Skip... * source Z39.50 100 Protect Skip... * Download and save from LOC control number 9162774. Verify it has 245 and 100 set * Edit record * Replace record via Z39.50 search * 245: was updated * 100: remained unchanged * Save record * 245: was updated * 100: was protected Hopefully an easy fix!
Hi Johanna, this is a rather bad bug. Could you have another look maybe?
I've retested this and I think the fix is correct, but there is another bug with the * rules not working as expected. I tested Z39.50 and Batch record modification with these rules: +----+-----+--------+----------+-----+--------+--------+--------+ | id | tag | module | filter | add | append | remove | delete | +----+-----+--------+----------+-----+--------+--------+--------+ | 3 | 245 | source | z3950 | 0 | 0 | 0 | 0 | | 4 | 300 | source | * | 0 | 0 | 0 | 0 | | 5 | 245 | source | batchmod | 0 | 0 | 0 | 0 | +----+-----+--------+----------+-----+--------+--------+--------+ With the patch applied * 245 was protected/unchanged in both cases = correct * 300 was unprotected/overwritten in both cases = incorrect So the * is not only an issue for z39.50 and I filed this separately as: Bug 33268 - Overlay rules don't work correctly when source is set to * Going to pass this, because it restores some of the promised functionality and works well!
Created attachment 148375 [details] [review] Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.12
applied to 21.11.x for 21.11.20