Bug 31011 - Make hold reminders respect patron's language
Summary: Make hold reminders respect patron's language
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 15986
Blocks:
  Show dependency treegraph
 
Reported: 2022-06-22 12:28 UTC by Magnus Enger
Modified: 2022-07-17 11:34 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2022-06-22 12:28:24 UTC
When running misc/cronjobs/holds/holds_reminder.pl it looks like borrowers.lang is not respected. The only code I can see that relates to language is this:

    # FIXME What if we don't want to default if the translated template does not exist?
    my $template_exists = Koha::Notice::Templates->find_effective_template(
        {
            module     => 'reserves',
            code       => $lettercode,
            branchcode => $branchcode,
            lang       => 'default',
        }
    );

As far as I can see, the "default" template is always used?
Comment 1 Katrin Fischer 2022-07-17 11:34:27 UTC
Still valid. There is also another bug that could possibly be fixed at the same time: 

Bug 28797 - Hold reminder email should use All Libraries notice