Bug 31040 - jsTree image being used outside of jsTree plugin
Summary: jsTree image being used outside of jsTree plugin
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 11873
Blocks:
  Show dependency tree / graph
 
Reported: 2022-06-24 11:37 UTC by Owen Leonard
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes OPAC templates which had a missing "spinner" image when queries were being performed (such as for OpenLibrary, RecordedBooks, and OverDrive). Previously, they were using an image from the jsTree plugin - this was upgraded (see bug 11873), and the plugin's folder structure was changed. Templates now use /images/spinner-small.gif instead.
Version(s) released in:
22.11.00, 22.05.04, 21.11.11
Circulation function:

Attachments
Bug 31040: jsTree image being used outside of jsTree plugin (7.64 KB, patch)
2022-06-24 11:57 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 31040: jsTree image being used outside of jsTree plugin (7.69 KB, patch)
2022-06-24 15:11 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31040: jsTree image being used outside of jsTree plugin (7.74 KB, patch)
2022-07-02 22:52 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-06-24 11:37:32 UTC 
Bug 11873 upgraded jsTree to the latest version, which included a change in the plugin's asset directory structure. Unfortunately this now highlights the fact that we were using one of jsTree's images for other aspects of the OPAC. 

For instance, the spinner image shown when search results show the "Searching OverDrive..." message.

These images are now broken. We don't need to depend on the plugin for this image, we have our "own" version.
Comment 1 Owen Leonard 2022-06-24 11:57:28 UTC 
Created attachment 136487 [details] [review]
Bug 31040: jsTree image being used outside of jsTree plugin

This patch corrects OPAC templates which tried to use a jsTree image
asset which is missing following the jsTree upgrade (see Bug 11873).
Templates should use /images/spinner-small.gif instead.

To test, apply the patch and enable OpenLibrarySearch and populate
OverDrive and RecordedBooks preferences with credentials (they don't
have to be valid).

Perform a catalog search in the OPAC. When the search results page first
loads you should see messages about the services being queried:

Searching OpenLibrary...
Searching RecordedBoks...
Searching OverDrive...

Each should show a working "spinner" image while the queries are being
performed. If you have valid OverDrive credentials you can try clicking
through to the OverDrive search results page to confirm that the image
is working on that page too.
Comment 2 David Nind 2022-06-24 15:11:36 UTC 
Created attachment 136512 [details] [review]
Bug 31040: jsTree image being used outside of jsTree plugin

This patch corrects OPAC templates which tried to use a jsTree image
asset which is missing following the jsTree upgrade (see Bug 11873).
Templates should use /images/spinner-small.gif instead.

To test, apply the patch and enable OpenLibrarySearch and populate
OverDrive and RecordedBooks preferences with credentials (they don't
have to be valid).

Perform a catalog search in the OPAC. When the search results page first
loads you should see messages about the services being queried:

Searching OpenLibrary...
Searching RecordedBoks...
Searching OverDrive...

Each should show a working "spinner" image while the queries are being
performed. If you have valid OverDrive credentials you can try clicking
through to the OverDrive search results page to confirm that the image
is working on that page too.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-06-24 15:13:47 UTC 
I don't have valid OverDrive credentials, so wasn't able to test accessing the search results page.
Comment 4 Katrin Fischer 2022-07-02 22:52:55 UTC 
Created attachment 137047 [details] [review]
Bug 31040: jsTree image being used outside of jsTree plugin

This patch corrects OPAC templates which tried to use a jsTree image
asset which is missing following the jsTree upgrade (see Bug 11873).
Templates should use /images/spinner-small.gif instead.

To test, apply the patch and enable OpenLibrarySearch and populate
OverDrive and RecordedBooks preferences with credentials (they don't
have to be valid).

Perform a catalog search in the OPAC. When the search results page first
loads you should see messages about the services being queried:

Searching OpenLibrary...
Searching RecordedBoks...
Searching OverDrive...

Each should show a working "spinner" image while the queries are being
performed. If you have valid OverDrive credentials you can try clicking
through to the OverDrive search results page to confirm that the image
is working on that page too.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-07-05 12:23:40 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass (lukeg) 2022-08-09 22:14:36 UTC 
Backported to 22.05.x for 22.05.04
Comment 7 Arthur Suzuki 2022-08-12 07:53:35 UTC 
Pushed to 21.11.x for 21.11.11
Comment 8 Victor Grousset/tuxayo 2022-08-17 22:39:52 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.