Bug 31054 - Manual importing for EDIFACT invoices fails with a 500 error page
Summary: Manual importing for EDIFACT invoices fails with a 500 error page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-27 12:13 UTC by Kyle M Hall (khall)
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05, 21.11.12
Circulation function:

Attachments
Bug 31054 - Manual importing for EDIFACT invoices fails with a 500 error page (1.65 KB, patch)
2022-06-27 12:16 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 31054: Manual importing for EDIFACT invoices fails with a 500 error page (1.71 KB, patch)
2022-07-11 06:32 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2022-06-27 12:13:25 UTC 
Error in plack log is: Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin" (perhaps you forgot to load "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin"?) at /usr/share/koha/lib/Koha/EDI.pm line 219.
Comment 1 Kyle M Hall (khall) 2022-06-27 12:16:42 UTC 
Created attachment 136574 [details] [review]
Bug 31054 - Manual importing for EDIFACT invoices fails with a 500 error page

Error in plack log is: Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin" (perhaps you forgot to load "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin"?) at /usr/share/koha/lib/Koha/EDI.pm line 219.

Test Plan:
1) Set EdifactInvoiceImport to "Don't"
2) Configure an EDI vendor to use an EDIFACT plugin
3) Attempt to import an invoice file
4) You will be shown an error page
5) Apply this patch
6) Restart all the things!
7) Attempt to import another invoice file
8) It works!
Comment 2 Martin Renvoize (ashimema) 2022-07-11 06:32:35 UTC 
Created attachment 137460 [details] [review]
Bug 31054: Manual importing for EDIFACT invoices fails with a 500 error page

Error in plack log is: Can't locate object method "new" via package
"Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin" (perhaps you
forgot to load "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin"?)
at /usr/share/koha/lib/Koha/EDI.pm line 219.

Test Plan:
1) Set EdifactInvoiceImport to "Don't"
2) Configure an EDI vendor to use an EDIFACT plugin
3) Attempt to import an invoice file
4) You will be shown an error page
5) Apply this patch
6) Restart all the things!
7) Attempt to import another invoice file
8) It works!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2022-07-11 06:33:25 UTC 
Trivial fix, works as expected with no regressions found..

Going straight for QA.. Passed.
Comment 4 Tomás Cohen Arazi (tcohen) 2022-07-11 21:24:00 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass (lukeg) 2022-08-23 15:51:49 UTC 
Backported to 22.05.05
Comment 6 Arthur Suzuki 2022-08-30 09:16:39 UTC 
thx pushed to 21.11.x for 21.11.12
Comment 7 Victor Grousset/tuxayo 2022-09-09 19:59:51 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.