In the Calendar tool it would be helpful to add text to the 'To Date' box indicating that the date only should be entered for holidays on a range. As it is now, if you are entering a single holiday, or holiday repeated weekly, or holiday repeated yearly, the 'To Date' field has no effect, nor is the information entered in the box retained. This is very confusing, especially to new users. I suggest adding 'Only used with holidays on a range' either next to or under the 'To Date' box.
Created attachment 146460 [details] [review] Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before
Created attachment 146464 [details] [review] Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Thank you, Matt!
.. all the [$] should be [?] of course... seeing yesterday's typos with freh eyes today
Created attachment 148318 [details] [review] Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Katrin Fischer from comment #4) > .. all the [$] should be [?] of course... seeing yesterday's typos with freh > eyes today The description is very obscure. But no problem.
Thx for QA!
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply clean in 22.05.x, no backport.