Bug 31057 - Add clarifying text to 'To date' in the calendar tool
Summary: Add clarifying text to 'To date' in the calendar tool
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Holidays (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-27 19:13 UTC by Donna
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 31057: Add hint to the 'To date' input on the calendar form (2.34 KB, patch)
2023-02-09 22:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31057: Add hint to the 'To date' input on the calendar form (2.42 KB, patch)
2023-02-10 09:14 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 31057: Add hint to the 'To date' input on the calendar form (2.50 KB, patch)
2023-03-17 09:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Donna 2022-06-27 19:13:41 UTC
In the Calendar tool it would be helpful to add text to the 'To Date' box indicating that the date only should be entered for holidays on a range.  

As it is now, if you are entering a single holiday, or holiday repeated weekly, or holiday repeated yearly, the 'To Date' field has no effect, nor is the information entered in the box retained.

This is very confusing, especially to new users.

I suggest adding 'Only used with holidays on a range' either next to or under the 'To Date' box.
Comment 1 Katrin Fischer 2023-02-09 22:39:42 UTC
Created attachment 146460 [details] [review]
Bug 31057: Add hint to the 'To date' input on the calendar form

Just adding a hint using the 'hint' class didn't work as
expected here. The hint was immediately hidden. That is
because of the collapsable hint text for the option at
the bottom of the form using the [?] link. So I chose to
use the class of the [$] to make the script a little more
selective.

To test:
* Go to the calendar tool
* Test that the [$] hide/show different help texts
* Apply patch
* Verify a hint now shows below the "To date"
* Verify that the help texts still function as before
Comment 2 Matt Blenkinsop 2023-02-10 09:14:53 UTC
Created attachment 146464 [details] [review]
Bug 31057: Add hint to the 'To date' input on the calendar form

Just adding a hint using the 'hint' class didn't work as
expected here. The hint was immediately hidden. That is
because of the collapsable hint text for the option at
the bottom of the form using the [?] link. So I chose to
use the class of the [$] to make the script a little more
selective.

To test:
* Go to the calendar tool
* Test that the [$] hide/show different help texts
* Apply patch
* Verify a hint now shows below the "To date"
* Verify that the help texts still function as before

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-02-10 09:21:11 UTC
Thank you, Matt!
Comment 4 Katrin Fischer 2023-02-10 09:22:07 UTC
.. all the [$] should be [?] of course... seeing yesterday's typos with freh eyes today
Comment 5 Marcel de Rooy 2023-03-17 09:19:29 UTC
Created attachment 148318 [details] [review]
Bug 31057: Add hint to the 'To date' input on the calendar form

Just adding a hint using the 'hint' class didn't work as
expected here. The hint was immediately hidden. That is
because of the collapsable hint text for the option at
the bottom of the form using the [?] link. So I chose to
use the class of the [$] to make the script a little more
selective.

To test:
* Go to the calendar tool
* Test that the [$] hide/show different help texts
* Apply patch
* Verify a hint now shows below the "To date"
* Verify that the help texts still function as before

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2023-03-17 09:20:11 UTC
(In reply to Katrin Fischer from comment #4)
> .. all the [$] should be [?] of course... seeing yesterday's typos with freh
> eyes today

The description is very obscure. But no problem.
Comment 7 Katrin Fischer 2023-03-17 10:44:36 UTC
Thx for QA!
Comment 8 Tomás Cohen Arazi 2023-04-06 12:52:19 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Jacob O'Mara 2023-04-16 20:37:02 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 10 Lucas Gass 2023-05-05 21:44:34 UTC
Doesn't apply clean in 22.05.x, no backport.