Bug 31062 - Change description of QOTD tool in tools-home
Summary: Change description of QOTD tool in tools-home
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Caroline Cyr La Rose
QA Contact: Fridolin Somers
URL:
Keywords:
Depends on:
Blocks: 31063
  Show dependency treegraph
 
Reported: 2022-06-28 21:34 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/679
Text to go in the release notes:
This enhancement changes the name and description of the QOTD tool in order to make them more consistent with the other tool names and descriptions.
Version(s) released in:
22.11.00, 22.05.04, 21.11.11
Circulation function:


Attachments
Bug 31062: Change description of QOTD tool in tools-home (1.58 KB, patch)
2022-06-28 21:39 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31062: Change description of QOTD tool in tools-home (1.63 KB, patch)
2022-06-29 00:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 31062: Change description of QOTD tool in tools-home (1.42 KB, patch)
2022-06-29 15:14 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31062: Change description of QOTD tool in tools-home (1.47 KB, patch)
2022-06-29 18:32 UTC, David Nind
Details | Diff | Splinter Review
Bug 31062: Change description of QOTD tool in tools-home (1.53 KB, patch)
2022-06-30 05:29 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-06-28 21:34:26 UTC
In the tools home page, the description for the QOTD tool currently says
"Quote editor for Quote-of-the-day feature in OPAC". This feature was extended to the staff interface in bug 16371.

Also, this is the only(?) tool whose title is an action and description is a noun. I would switch them.

Tool title: Quote editor for 'Quote of the day' feature
Description: Edit quotes for the 'Quote of the day' feature in OPAC and staff interface

That way, it would be more constant with the other tool names and descriptions.
Comment 1 Caroline Cyr La Rose 2022-06-28 21:39:16 UTC
Created attachment 136700 [details] [review]
Bug 31062: Change description of QOTD tool in tools-home

This patch changes the name and description of the QOTD tool
in order to make them more constant with the other tool names
and descriptions, and to include the fact that QOTD can now be
used in the staff interface as well as the OPAC.

To test:
1) Go to Tools
2) Read the QOTD tool name and description, make sure they make
   sense and that there are no typos
3) Test the link to make sure it goes to the tool
Comment 2 David Nind 2022-06-29 00:48:16 UTC
Created attachment 136701 [details] [review]
Bug 31062: Change description of QOTD tool in tools-home

This patch changes the name and description of the QOTD tool
in order to make them more constant with the other tool names
and descriptions, and to include the fact that QOTD can now be
used in the staff interface as well as the OPAC.

To test:
1) Go to Tools
2) Read the QOTD tool name and description, make sure they make
   sense and that there are no typos
3) Test the link to make sure it goes to the tool

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-06-29 00:56:50 UTC
Thanks for doing this Caroline! 

I always thought it was a bit inconsistent with how the other tools are named and described (but hadn't got around to creating a bug!).

I'm probably being picky, but my suggestion/further refinements would be:

  QOTD editor or Quote editor (used in the breadcrumb on the quotes page)

    Manage quotes (no other tool mentions feature) or Manage 'Quote of the day' quotes
Comment 4 Caroline Cyr La Rose 2022-06-29 15:14:33 UTC
Created attachment 136740 [details] [review]
Bug 31062: Change description of QOTD tool in tools-home

This patch changes the name and description of the QOTD tool in order
to make them more consistent with the other tool names and descriptions.

To test:
1) Go to Tools
2) Read the QOTD tool name and description, make sure they make
   sense and that there are no typos
3) Test the link to make sure it goes to the tool
Comment 5 Caroline Cyr La Rose 2022-06-29 15:16:23 UTC
I changed it to
Name: Quote editor
Description: Manage 'Quote of the day' quotes

It's more compact and consistent, but we lose the fact that it can be used in OPAC and staff. I guess it's not that important
Comment 6 David Nind 2022-06-29 18:32:38 UTC
Created attachment 136747 [details] [review]
Bug 31062: Change description of QOTD tool in tools-home

This patch changes the name and description of the QOTD tool in order
to make them more consistent with the other tool names and descriptions.

To test:
1) Go to Tools
2) Read the QOTD tool name and description, make sure they make
   sense and that there are no typos
3) Test the link to make sure it goes to the tool

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Fridolin Somers 2022-06-30 05:29:34 UTC
Created attachment 136765 [details] [review]
Bug 31062: Change description of QOTD tool in tools-home

This patch changes the name and description of the QOTD tool in order
to make them more consistent with the other tool names and descriptions.

To test:
1) Go to Tools
2) Read the QOTD tool name and description, make sure they make
   sense and that there are no typos
3) Test the link to make sure it goes to the tool

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Comment 8 Tomás Cohen Arazi (tcohen) 2022-07-01 19:43:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Caroline Cyr La Rose 2022-07-04 12:54:12 UTC
This will need an update of the manual. I'm not sure in the new workflow when this is supposed to be changed to "Needs documenting".
Comment 10 Katrin Fischer 2022-07-04 12:57:36 UTC
(In reply to Caroline Cyr La Rose from comment #9)
> This will need an update of the manual. I'm not sure in the new workflow
> when this is supposed to be changed to "Needs documenting".

The last RMaint to look at this will set 'Needs documenting'.
Comment 11 Lucas Gass (lukeg) 2022-08-09 22:00:40 UTC
Backported to 22.05.x for 22.05.04
Comment 12 Arthur Suzuki 2022-08-12 07:28:58 UTC
pushed to 21.11.x for 21.11.11
Comment 13 Victor Grousset/tuxayo 2022-08-17 19:43:15 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.


(In reply to Caroline Cyr La Rose from comment #9)
> This will need an update of the manual. I'm not sure in the new workflow
> when this is supposed to be changed to "Needs documenting".

Thanks for saying it, I would have wrongly guessed that it changed nothing.