Bug 31083 - Part name (245$p) breaks item bundle detail view
Summary: Part name (245$p) breaks item bundle detail view
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 28854
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-01 13:46 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31083: Fix part_name handling in js-biblio-format (2.24 KB, patch)
2022-07-04 10:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31083: Fix part_name handling in js-biblio-format (2.30 KB, patch)
2022-07-08 10:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-07-01 13:46:35 UTC
When displaying the contents of an item bundle, it would be nice to have more complete item information including the subtitle, part_name and part_number field as this helps greatly in identifying records especially for such things as language materials.
Comment 1 Martin Renvoize 2022-07-01 15:07:18 UTC
So, for me this is already working in bug 28854.. I've tested against subtitles especially but the code is also there for part numbers/names.
Comment 2 Katrin Fischer 2022-07-02 19:45:55 UTC
I think it was an issue with the sample data. I've checked the mappings and updated records to make sure the fields are set in the database.

It does work, but we are missing spaces between the fields:

CSS :the definitive guide /
Should be: CSS : the definitive guide /

Also, when I add a part_name (245$p) the bundle manage view throws an error and sends the display into eternal processing:

Uncaught ReferenceError: part_name is not defined

My catalogued 245 was:

245 	1 	0 	_aCSS :
_bthe definitive guide /
_cEric A. Meyer.
_nnumber1
_ppart1
_nnumber2
_ppart2
Comment 3 Martin Renvoize 2022-07-04 10:51:51 UTC
Created attachment 137055 [details] [review]
Bug 31083: Fix part_name handling in js-biblio-format

This patch corrects the typo introduced in bug 28854 for part_name
handling in the js-biblio-format include.  We also introduce proper
whitespace addition when concatenating subtitle, medium and parts to the
title string.
Comment 4 Martin Renvoize 2022-07-04 10:53:10 UTC
Good catch.. I hadn't tested the part_name piece of this and had introduced a typo!

I also add in some whitespace handling for the various title parts as prior to now the title and subtitle and other fields would all be concatenated without spaces between.
Comment 5 Katrin Fischer 2022-07-08 10:12:10 UTC
Created attachment 137402 [details] [review]
Bug 31083: Fix part_name handling in js-biblio-format

This patch corrects the typo introduced in bug 28854 for part_name
handling in the js-biblio-format include.  We also introduce proper
whitespace addition when concatenating subtitle, medium and parts to the
title string.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 Tomás Cohen Arazi 2022-07-18 14:53:50 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-08-23 17:23:20 UTC
Missing dependencies for 22.05.x, no backport