Bug 31116 - Article requests doesn't respect the 'CircSidebar' preference
Summary: Article requests doesn't respect the 'CircSidebar' preference
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-07 11:16 UTC by Martin Renvoize
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31116: Add circulation sidebar to article requests (3.08 KB, patch)
2022-07-07 11:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31116: Add circulation sidebar to article requests (3.11 KB, patch)
2022-07-07 14:27 UTC, David Nind
Details | Diff | Splinter Review
Bug 31116: Add circulation sidebar to article requests (3.21 KB, patch)
2022-07-08 06:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31116: (QA follow-up) Remove duplicate line (931 bytes, patch)
2022-07-08 06:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-07-07 11:16:22 UTC
The article requests management page doesn't ever display the circulation side menu.. it should when CircSidebar is enabled.
Comment 1 Martin Renvoize 2022-07-07 11:41:36 UTC
Created attachment 137269 [details] [review]
Bug 31116: Add circulation sidebar to article requests

This patch adds the circulation sidebar menu to the article requests
page to make it consistent with other circulation module pages.

Test plan
1) Prior to applying the patch confirm that there is no sidebar on the
   article requests management page, regardless of the CircSidebar
   perference.
2) Apply the patch
3) Confirm there is still no sidebar when CircSidebar is disabled
4) Confirm there is now a sidebar present when CircSidebar is enabled
5) Confirm the current page is highlighted correctly in the sidebar when
   on the article requests page.
Comment 2 David Nind 2022-07-07 14:27:46 UTC
Created attachment 137313 [details] [review]
Bug 31116: Add circulation sidebar to article requests

This patch adds the circulation sidebar menu to the article requests
page to make it consistent with other circulation module pages.

Test plan
1) Prior to applying the patch confirm that there is no sidebar on the
   article requests management page, regardless of the CircSidebar
   perference.
2) Apply the patch
3) Confirm there is still no sidebar when CircSidebar is disabled
4) Confirm there is now a sidebar present when CircSidebar is enabled
5) Confirm the current page is highlighted correctly in the sidebar when
   on the article requests page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2022-07-08 06:09:24 UTC
Created attachment 137361 [details] [review]
Bug 31116: Add circulation sidebar to article requests

This patch adds the circulation sidebar menu to the article requests
page to make it consistent with other circulation module pages.

Test plan
1) Prior to applying the patch confirm that there is no sidebar on the
   article requests management page, regardless of the CircSidebar
   perference.
2) Apply the patch
3) Confirm there is still no sidebar when CircSidebar is disabled
4) Confirm there is now a sidebar present when CircSidebar is enabled
5) Confirm the current page is highlighted correctly in the sidebar when
   on the article requests page.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2022-07-08 06:09:28 UTC
Created attachment 137362 [details] [review]
Bug 31116: (QA follow-up) Remove duplicate line

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2022-07-08 06:11:12 UTC
My only comment would be: Article requests is considered as Circulation, so it would be fine for me if it would have been listed under Circulation. Patron request is added now. All circulation stuff is based on 'patron requests' ;)
Comment 6 Martin Renvoize 2022-07-08 13:32:41 UTC
I totally agree actually.. I just followed what the circulation-home page does in terms of splitting them.

I'd be happy to remove the 'Patron requests' section from both and move 'Article requests' under circulation for consistency.
Comment 7 Tomás Cohen Arazi 2022-07-11 21:24:12 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-08-23 15:49:15 UTC
Doesn't apply clean to 22.05.x, no backport. If needed please rebase