The article requests management page doesn't ever display the circulation side menu.. it should when CircSidebar is enabled.
Created attachment 137269 [details] [review] Bug 31116: Add circulation sidebar to article requests This patch adds the circulation sidebar menu to the article requests page to make it consistent with other circulation module pages. Test plan 1) Prior to applying the patch confirm that there is no sidebar on the article requests management page, regardless of the CircSidebar perference. 2) Apply the patch 3) Confirm there is still no sidebar when CircSidebar is disabled 4) Confirm there is now a sidebar present when CircSidebar is enabled 5) Confirm the current page is highlighted correctly in the sidebar when on the article requests page.
Created attachment 137313 [details] [review] Bug 31116: Add circulation sidebar to article requests This patch adds the circulation sidebar menu to the article requests page to make it consistent with other circulation module pages. Test plan 1) Prior to applying the patch confirm that there is no sidebar on the article requests management page, regardless of the CircSidebar perference. 2) Apply the patch 3) Confirm there is still no sidebar when CircSidebar is disabled 4) Confirm there is now a sidebar present when CircSidebar is enabled 5) Confirm the current page is highlighted correctly in the sidebar when on the article requests page. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 137361 [details] [review] Bug 31116: Add circulation sidebar to article requests This patch adds the circulation sidebar menu to the article requests page to make it consistent with other circulation module pages. Test plan 1) Prior to applying the patch confirm that there is no sidebar on the article requests management page, regardless of the CircSidebar perference. 2) Apply the patch 3) Confirm there is still no sidebar when CircSidebar is disabled 4) Confirm there is now a sidebar present when CircSidebar is enabled 5) Confirm the current page is highlighted correctly in the sidebar when on the article requests page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 137362 [details] [review] Bug 31116: (QA follow-up) Remove duplicate line Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
My only comment would be: Article requests is considered as Circulation, so it would be fine for me if it would have been listed under Circulation. Patron request is added now. All circulation stuff is based on 'patron requests' ;)
I totally agree actually.. I just followed what the circulation-home page does in terms of splitting them. I'd be happy to remove the 'Patron requests' section from both and move 'Article requests' under circulation for consistency.
Pushed to master for 22.11. Nice work everyone, thanks!
Doesn't apply clean to 22.05.x, no backport. If needed please rebase