Bug 31132 - Add button to clear the cataloguing authority plugin form
Summary: Add button to clear the cataloguing authority plugin form
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-11 22:50 UTC by Koha Training Catalyst
Modified: 2024-01-22 16:56 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/821
Text to go in the release notes:
This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records.
Version(s) released in:
23.11.00


Attachments
Bug 31132: Add button to clear the cataloguing auth finder form (2.35 KB, patch)
2022-07-11 23:10 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 31132: Add button to clear the cataloguing auth finder form (2.40 KB, patch)
2022-07-11 23:32 UTC, David Nind
Details | Diff | Splinter Review
Bug 31132: (follow-up) Reset dropdown values and style button (2.81 KB, patch)
2022-07-12 04:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 31132: (follow-up) Reset dropdown values and style button (3.80 KB, patch)
2022-07-25 03:43 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 31132: Add button to clear the cataloguing auth finder form (2.44 KB, patch)
2023-05-04 20:47 UTC, Nicolas Giraud
Details | Diff | Splinter Review
Bug 31132: (follow-up) Reset dropdown values and style button (3.81 KB, patch)
2023-05-04 20:47 UTC, Nicolas Giraud
Details | Diff | Splinter Review
Bug 31132: Add button to clear the cataloguing auth finder form (2.50 KB, patch)
2023-05-08 21:56 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31132: (follow-up) Reset dropdown values and style button (3.86 KB, patch)
2023-05-08 21:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Training Catalyst 2022-07-11 22:50:18 UTC
Add a button that will empty all of the search fields in the authority finder plugin when cataloguing biblios
Comment 1 Aleisha Amohia 2022-07-11 23:10:07 UTC
Created attachment 137595 [details] [review]
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS
Comment 2 David Nind 2022-07-11 23:32:44 UTC
Created attachment 137596 [details] [review]
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Aleisha Amohia 2022-07-12 04:50:48 UTC
Created attachment 137601 [details] [review]
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.
Comment 4 David Nind 2022-07-12 19:38:41 UTC
For me, the clear form works initially:
1. Authority finder launched for a tag
2. Clear form is styled as a text link
3. Click 'Clear form' ==> text form fields are cleared
4. For the 'Search main heading ($a only)' change to 'starts with' and enter perl as the term (don't press the search button)
5. Click 'Clear form' ==> form reset, including options and text entered

However, for step 4, if you click search, and search results are displayed:
1. The 'Clear form' button is now styled as a button, rather than a link
2. Clicking 'Clear form' now only clears the text but not the options
3. The results from the previous search are still displayed
Comment 5 Aleisha Amohia 2022-07-25 03:43:28 UTC
Created attachment 138069 [details] [review]
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.

Test that the button looks and behaves as expected after submitting a
search.
Comment 6 Katrin Fischer 2022-07-25 21:15:22 UTC
The feature itself works nicely, but I am not sure about the placement of the link as it 'breaks the rule' of the Cancel link always being next to the submit button.

Looking at the Z39.50 search pop-up, the clear form links is placed inside the form. Maybe we should do the same here.
Comment 7 Nicolas Giraud 2023-05-04 20:47:38 UTC
Created attachment 150696 [details] [review]
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: nicolas <nicolas@inlibro.com>
Comment 8 Nicolas Giraud 2023-05-04 20:47:40 UTC
Created attachment 150697 [details] [review]
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.

Test that the button looks and behaves as expected after submitting a
search.

Signed-off-by: nicolas <nicolas@inlibro.com>
Comment 9 Katrin Fischer 2023-05-08 21:56:47 UTC
Created attachment 150814 [details] [review]
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: nicolas <nicolas@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2023-05-08 21:56:50 UTC
Created attachment 150815 [details] [review]
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.

Test that the button looks and behaves as expected after submitting a
search.

Signed-off-by: nicolas <nicolas@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Tomás Cohen Arazi 2023-06-23 14:03:52 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Martin Renvoize 2023-07-17 14:35:40 UTC
Enhancement, won't be backported to 23.05.x series
Comment 13 Caroline Cyr La Rose 2024-01-22 16:56:13 UTC
I only updated the screenshots in the manual.