While editing a label template, you may choose a Printer Profile for Patroncards resulting in an error 500 when saving the changes. Can't bless non-reference value at /home/adolfo/workspace/koha-master/C4/Creators/Profile.pm line 88 It's the same error described on bug 24001, but in Labels instead of Patron cards https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
Created attachment 137607 [details] [review] Fix Bug 31137 - Error editing label template This patch filters the printer profiles in the label edition template so you may only choose Printer Profiles created for Labels. To test 1 Create a new Printer Profile in Patron Cards 2 Edit a Label template, pick the Printer Profile you just created. 3 Save the Label Template. You get an error 500 4 apply patch, restart services 5 Edit a Label template and check that you can't pick the Printer Profile you created in Patron Cards
Created attachment 137749 [details] [review] Fix - Bug 31137 - Error editing label template Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 137750 [details] [review] Bug 31137: (QA follow-up) Also fix new template page Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 137751 [details] [review] Bug 31137: Only display label printer profiles when editing labels This patch filters the printer profiles in the label edition template so you may only choose Printer Profiles created for Labels. To test 1 Create a new Printer Profile in Patron Cards 2 Edit a Label template, pick the Printer Profile you just created. 3 Save the Label Template. You get an error 500 4 apply patch, restart services 5 Edit a Label template and check that you can't pick the Printer Profile you created in Patron Cards Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 137752 [details] [review] Bug 31137: (QA follow-up) Also fix new template page Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Straightforward - PQA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
thx pushed to 21.11.x for 21.11.12
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.