Bug 31139 - basic_workflow.t is failing
Summary: basic_workflow.t is failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 09:35 UTC by Jonathan Druart
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05, 21.11.12


Attachments
Bug 31139: Fix basic_workflow.t (1.95 KB, patch)
2022-07-12 09:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31139: Fix basic_workflow.t (2.00 KB, patch)
2022-07-12 11:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 31139: Fix basic_workflow.t (2.05 KB, patch)
2022-07-14 22:18 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-07-12 09:35:48 UTC
Error while executing command: element not interactable: Element <input id="tag_952_subfield_w_810691" class="input_marceditor items.replacementpricedate noEnterSubmit flatpickr-input" name="items.replacementpricedate" type="hidden"> is not reachable by keyboard at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.
Comment 1 Jonathan Druart 2022-07-12 09:36:51 UTC
Not sure if it's coming from bug 30717 or not. git bisect told me it was the culprit but we released 22.05 and it seems that we got basic_workflow.t green since then.
Comment 2 Jonathan Druart 2022-07-12 09:37:39 UTC
Created attachment 137614 [details] [review]
Bug 31139: Fix basic_workflow.t

Error while executing command: element not interactable: Element <input id="tag_952_subfield_w_810691" class="input_marceditor items.replacementpricedate noEnterSubmit flatpickr-input" name="items.replacementpricedate" type="hidden"> is not reachable by keyboard at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

Not sure if it's coming from bug 30717 or not. git bisect told me it was the culprit but we released 22.05 and it seems that we got basic_workflow.t green since then.
Comment 3 David Nind 2022-07-12 11:25:39 UTC
Created attachment 137619 [details] [review]
Bug 31139: Fix basic_workflow.t

Error while executing command: element not interactable: Element <input id="tag_952_subfield_w_810691" class="input_marceditor items.replacementpricedate noEnterSubmit flatpickr-input" name="items.replacementpricedate" type="hidden"> is not reachable by keyboard at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

Not sure if it's coming from bug 30717 or not. git bisect told me it was the culprit but we released 22.05 and it seems that we got basic_workflow.t green since then.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-07-12 11:27:01 UTC
Testing notes (using koha-testing-docker):

1. Tests fail before applying the patch: prove t/db_dependent/selenium/basic_workflow.t

2. Tests now pass after applying the patch.
Comment 5 Victor Grousset/tuxayo 2022-07-14 22:18:39 UTC
Created attachment 137739 [details] [review]
Bug 31139: Fix basic_workflow.t

Error while executing command: element not interactable: Element <input id="tag_952_subfield_w_810691" class="input_marceditor items.replacementpricedate noEnterSubmit flatpickr-input" name="items.replacementpricedate" type="hidden"> is not reachable by keyboard at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

Not sure if it's coming from bug 30717 or not. git bisect told me it was the culprit but we released 22.05 and it seems that we got basic_workflow.t green since then.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2022-07-14 22:21:24 UTC
Works, qa script happy, code looks good, passing QA :)
Comment 7 Tomás Cohen Arazi 2022-07-15 13:51:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-08-23 16:06:02 UTC
Backported to 22.05.x for 22.05.05
Comment 9 Arthur Suzuki 2022-08-30 09:18:57 UTC
thx pushed to 21.11.x for 21.11.12
Comment 10 Victor Grousset/tuxayo 2022-09-09 23:48:27 UTC
Not backported to oldoldstable (21.05.x). Doesn't look affected from what I recall and after checking the recent failures. Will come back if basic_workflow.t starts giving trouble.

Nothing to document, marking resolved.