Bug 31140 - TestBuilder.t is failing on item groups modules
Summary: TestBuilder.t is failing on item groups modules
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 24857
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-12 10:11 UTC by Kyle M Hall
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31140: TestBuilder.t is failing on item groups modules (1.11 KB, patch)
2022-07-12 10:15 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31140: TestBuilder.t is failing on item groups modules (1.15 KB, patch)
2022-07-12 11:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 31140: TestBuilder.t is failing on item groups modules (1.21 KB, patch)
2022-07-12 13:32 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 31140: (QA follow-up) Remove leftover POD (661 bytes, patch)
2022-07-12 13:45 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2022-07-12 10:11:57 UTC

    
Comment 1 Kyle M Hall 2022-07-12 10:15:02 UTC
Created attachment 137616 [details] [review]
Bug 31140: TestBuilder.t is failing on item groups modules

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note failures
3) Apply this patch
4) prove t/db_dependent/TestBuilder.t
5) Note all tests pass!
Comment 2 David Nind 2022-07-12 11:36:11 UTC
Created attachment 137620 [details] [review]
Bug 31140: TestBuilder.t is failing on item groups modules

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note failures
3) Apply this patch
4) prove t/db_dependent/TestBuilder.t
5) Note all tests pass!

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Tomás Cohen Arazi 2022-07-12 13:32:15 UTC
Created attachment 137627 [details] [review]
Bug 31140: TestBuilder.t is failing on item groups modules

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note failures
3) Apply this patch
4) prove t/db_dependent/TestBuilder.t
5) Note all tests pass!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2022-07-12 13:34:07 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Tomás Cohen Arazi 2022-07-12 13:45:22 UTC
Created attachment 137629 [details] [review]
Bug 31140: (QA follow-up) Remove leftover POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Lucas Gass 2022-08-23 15:54:22 UTC
Missing dependencies for 22.05.x, no backport