Bug 31145 - Add some defaults for acquisitions in TestBuilder
Summary: Add some defaults for acquisitions in TestBuilder
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 18:52 UTC by Nick Clemens
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05, 21.11.12


Attachments
Bug 31145: Supply defaults for vendors and funds (1.34 KB, patch)
2022-07-12 18:54 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31145: Supply defaults for vendors and funds (1.40 KB, patch)
2022-07-12 19:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-07-12 18:52:14 UTC
This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without removing this
2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering
Comment 1 Nick Clemens 2022-07-12 18:54:18 UTC
Created attachment 137653 [details] [review]
Bug 31145: Supply defaults for vendors and funds

This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without removing this
2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering

To test:
1 - Apply patch
2 - Restart all
3 - Edit 'My vendor'
4 - note webstie is empty and you can save without changing anythign
5 - Add order to basket for my vendor
6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as text input fields
Comment 2 Nick Clemens 2022-07-12 18:54:37 UTC
'reset_all' that is
Comment 3 Tomás Cohen Arazi 2022-07-12 19:04:14 UTC
Created attachment 137654 [details] [review]
Bug 31145: Supply defaults for vendors and funds

This is a convenience bug - when koha testing docker creates sample vendors and budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without removing this
2 - The funds have random values for statistical categories, and you get empty dropdowns when choosing a fund in ordering

To test:
1 - Apply patch
2 - Restart all
3 - Edit 'My vendor'
4 - note webstie is empty and you can save without changing anythign
5 - Add order to basket for my vendor
6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as text input fields

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2022-07-12 19:04:49 UTC
QA script happy. Simple change. Straight QA.
Comment 5 Tomás Cohen Arazi 2022-07-13 15:23:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Jonathan Druart 2022-07-13 15:38:46 UTC
Not a big deal but this one seems weird to me. Why don't you pass the data you need instead?
Comment 7 Nick Clemens 2022-07-13 16:20:46 UTC
(In reply to Jonathan Druart from comment #6)
> Not a big deal but this one seems weird to me. Why don't you pass the data
> you need instead?

TestBuilder is never going to put useful info here, seemed reasonable to default to NULL

I don't need anything in these, but it did sometime interfere with testing or demo when fields had to be corrected
Comment 8 Lucas Gass 2022-08-23 16:00:58 UTC
Backported to 22.05.x for 22.05.05
Comment 9 Arthur Suzuki 2022-08-30 09:18:31 UTC
thx pushed to 21.11.x for 21.11.12
Comment 10 Victor Grousset/tuxayo 2022-09-09 23:28:36 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.