Bug 31170 - Capitalization: Overdue Item Fine Description
Summary: Capitalization: Overdue Item Fine Description
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Isobel Graham
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 24865
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-17 09:04 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31170: Decapatalized "Overdue Item Fine Description" (1.15 KB, patch)
2022-09-01 10:50 UTC, Isobel Graham
Details | Diff | Splinter Review
Bug 31170: Decapatalized "Overdue Item Fine Description" (1.20 KB, patch)
2022-09-02 10:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31170: Decapatalized "Overdue Item Fine Description" (1.25 KB, patch)
2022-09-07 13:15 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31170: (QA follow-up) Fix capitalization in database update (1.30 KB, patch)
2022-09-07 13:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-07-17 09:04:34 UTC
Overdue Item Fine Description

The string is in the sample notices:
installer/data/mysql/en/mandatory/sample_notices.yml:letter:1:row:64
Comment 1 Isobel Graham 2022-09-01 10:50:55 UTC
Created attachment 140035 [details] [review]
Bug 31170: Decapatalized "Overdue Item Fine Description"

I changed "Overdue Item Fine Description" to
"Overdue item fine description" for both the
name and title.
Comment 2 Owen Leonard 2022-09-02 10:43:10 UTC
Created attachment 140101 [details] [review]
Bug 31170: Decapatalized "Overdue Item Fine Description"

I changed "Overdue Item Fine Description" to "Overdue item fine
description" for both the name and title.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2022-09-02 10:45:29 UTC
I've gone back and forth about whether this should include a database update too, but I think I'm good without one.
Comment 4 Katrin Fischer 2022-09-07 13:12:09 UTC
(In reply to Owen Leonard from comment #3)
> I've gone back and forth about whether this should include a database update
> too, but I think I'm good without one.

I agree with you - I think libraries might have changed it and we should not interrupt. But happy to see these stuff cleaned up for new installations.
Comment 5 Katrin Fischer 2022-09-07 13:14:27 UTC
(In reply to Katrin Fischer from comment #4)
> (In reply to Owen Leonard from comment #3)
> > I've gone back and forth about whether this should include a database update
> > too, but I think I'm good without one.
> 
> I agree with you - I think libraries might have changed it and we should not
> interrupt. But happy to see these stuff cleaned up for new installations.

Hah, this is a new 22.11 feature - so we are good :)
Comment 6 Katrin Fischer 2022-09-07 13:15:35 UTC
Created attachment 140282 [details] [review]
Bug 31170: Decapatalized "Overdue Item Fine Description"

I changed "Overdue Item Fine Description" to "Overdue item fine
description" for both the name and title.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-09-07 13:19:06 UTC
Created attachment 140283 [details] [review]
Bug 31170: (QA follow-up) Fix capitalization in database update

As this has not been released yet, we can also fix the database
update to not introduce the wrong capitalization in the first
place.
Comment 8 Tomás Cohen Arazi 2022-09-07 20:21:40 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!