Bug 31191 - Specify FacetLabelTruncationLength is only for Zebra
Summary: Specify FacetLabelTruncationLength is only for Zebra
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-19 19:13 UTC by Caroline Cyr La Rose
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/576
Text to go in the release notes:
This enhancement adds a note to the FacetLabelTruncationLength system preference description that it only works with Zebra. When using ElasticSearch, facets are displayed in full.
Version(s) released in:
22.11.00
Circulation function:


Attachments
Screenshot of facets with Zebra (11.27 KB, image/png)
2022-07-19 19:15 UTC, Caroline Cyr La Rose
Details
Screenshot of facets with Elasticsearch (15.45 KB, image/png)
2022-07-19 19:16 UTC, Caroline Cyr La Rose
Details
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra (1.43 KB, patch)
2022-07-19 19:25 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra (1.49 KB, patch)
2022-07-24 21:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-07-19 19:13:46 UTC
When using ElasticSearch, the FacetLabelTruncationLength system preference doesn't apply. I don't know if it's a bug or by design. Maybe it should be indicated in the syspref description that it only works with Zebra?

To test:
1) Change the searchengine syspref to Zebra
2) Reindex
3) Do a search
4) Check the facets
   --> The longer ones should be truncated to 20 characters
5) Change the seachengin syspref to Elasticsearch
6) Redo steps 2-4
   --> The longer facets are displayed in full
Comment 1 Caroline Cyr La Rose 2022-07-19 19:15:12 UTC
Created attachment 137885 [details]
Screenshot of facets with Zebra

This is a screenshot of facets with Zebra. Note that the longer ones are truncated with an ellipsis, e.g. "Association for Scot..."
Comment 2 Caroline Cyr La Rose 2022-07-19 19:16:14 UTC
Created attachment 137886 [details]
Screenshot of facets with Elasticsearch

This is a screenshot of facets with Elasticsearch. Note that the longer ones are there in full, e.g. "Association for Scottish Literary Studies"
Comment 3 Caroline Cyr La Rose 2022-07-19 19:18:06 UTC
In my test, I did not change the FacetLabelTruncationLength system preference when I changed search engines. 

I also did not specify staff interface or OPAC, but it does the same thing in both interfaces.
Comment 4 Caroline Cyr La Rose 2022-07-19 19:25:03 UTC
Created attachment 137887 [details] [review]
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra

This patch adds a note in the description of FacetLabelTruncationLength
that it only works with Zebra.

To test:
0) Apply patch
1) Go to Administration > Global system preference > Searching
preferences
2) Search for FacetLabelTruncationLength
3) Read the description, make sure it indicates that is requires Zebra
Comment 5 Caroline Cyr La Rose 2022-07-19 19:25:48 UTC
I changed the .pref file, I'm not sure if that's where it's changed or if it's the only place... Let me know.
Comment 6 Katrin Fischer 2022-07-24 21:25:45 UTC
Created attachment 138066 [details] [review]
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra

This patch adds a note in the description of FacetLabelTruncationLength
that it only works with Zebra.

To test:
0) Apply patch
1) Go to Administration > Global system preference > Searching
preferences
2) Search for FacetLabelTruncationLength
3) Read the description, make sure it indicates that is requires Zebra

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-07-24 21:26:49 UTC
String patch - passing QA too.
Comment 8 Tomás Cohen Arazi (tcohen) 2022-07-25 14:33:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass (lukeg) 2022-09-02 19:30:39 UTC
Enhancement will not be backported to 22.05.x series.
Comment 10 Martin Renvoize (ashimema) 2022-09-16 13:02:52 UTC
I merged the docs update.. thanks Caroline