Discovered this when trying to send the number of patron holds in a custom SIP field. If the value of a SIP field is "0", that evaluates to false, so any calls to maybe_add with a value of "0" will not get added to the SIP response message.
Created attachment 137941 [details] [review] Bug 31202 - Koha removes optional SIP fields with a value of "0" If the value of a SIP field is "0", that evaluates to false, so any calls to maybe_add with a value of "0" will not get added to the SIP response message. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t
Created attachment 137947 [details] [review] Bug 31202 - Koha removes optional SIP fields with a value of "0" If the value of a SIP field is "0", that evaluates to false, so any calls to maybe_add with a value of "0" will not get added to the SIP response message. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Michal Urban <michalurban177@gmail.com>
Created attachment 137988 [details] [review] Bug 31202: Don't remove optional SIP fields with a value of "0" If the value of a SIP field is "0", that evaluates to false, so any calls to maybe_add with a value of "0" will not get added to the SIP response message. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Michal Urban <michalurban177@gmail.com> JK: Adjust commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
Thanks! Pushed to 21.11 for 21.11.12
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.