Bug 31209 - Add a span with class around serial enumeration/chronology data in list of checkouts for better styling
Summary: Add a span with class around serial enumeration/chronology data in list of ch...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-21 07:06 UTC by Mathieu Saby
Modified: 2023-12-28 20:43 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11, 21.11.19
Circulation function:


Attachments
Bug 31209: Add a span with a class for items.enumchron in the checkouts list (1.44 KB, patch)
2023-02-09 22:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31209: Add a span with a class for items.enumchron in the checkouts list (1.49 KB, patch)
2023-02-15 09:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 31209: Add a span with a class for items.enumchron in the checkouts list (1.54 KB, patch)
2023-02-17 18:29 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2022-07-21 07:06:35 UTC
In the table issues-table of circulation.tt, enumchron data in added to the title between parentheses. There is no way to style this information differently from the title. We could add a span with a class to isolate this information. 

Alternatively, enumchron data could be moved in a new column
Comment 1 Lucas Gass (lukeg) 2022-07-21 22:32:39 UTC
I like the idea of it having its own column, that way you can sort issues by enumchron if needed
Comment 2 Katrin Fischer 2023-02-09 22:10:15 UTC
I think we should start with the span. More columns make the screen much wider and we already have a lot that libraries will want to display. The enumchron is also placed in the same spot in the list of checkins, but it has a class there that is also used here now.
Comment 3 Katrin Fischer 2023-02-09 22:11:05 UTC
Created attachment 146456 [details] [review]
Bug 31209: Add a span with a class for items.enumchron in the checkouts list

To test:
* Add or edit an item and add some info to the 'Serial Enumeration /
  chronology' field
* Check the item out
* Verify by checking the source code or using the element inspector
  that the title and enumchron have been merged into one string
* Apply patch
* Reload and verify that now the enumchron is wrapped in a span
  with class="item_enumeration" matching the class in the list of
  checkins
Comment 4 David Nind 2023-02-15 09:48:08 UTC
Created attachment 146673 [details] [review]
Bug 31209: Add a span with a class for items.enumchron in the checkouts list

To test:
* Add or edit an item and add some info to the 'Serial Enumeration /
  chronology' field
* Check the item out
* Verify by checking the source code or using the element inspector
  that the title and enumchron have been merged into one string
* Apply patch
* Reload and verify that now the enumchron is wrapped in a span
  with class="item_enumeration" matching the class in the list of
  checkins

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Kyle M Hall (khall) 2023-02-17 18:29:10 UTC
Created attachment 146902 [details] [review]
Bug 31209: Add a span with a class for items.enumchron in the checkouts list

To test:
* Add or edit an item and add some info to the 'Serial Enumeration /
  chronology' field
* Check the item out
* Verify by checking the source code or using the element inspector
  that the title and enumchron have been merged into one string
* Apply patch
* Reload and verify that now the enumchron is wrapped in a span
  with class="item_enumeration" matching the class in the list of
  checkins

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-02-20 12:44:52 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize (ashimema) 2023-02-24 08:31:29 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 8 Lucas Gass (lukeg) 2023-03-01 14:38:05 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-29 09:15:08 UTC
applied to 21.11.x for 21.11.19
Comment 10 Wainui Witika-Park 2023-04-27 03:56:51 UTC
Not backported to 21.05.x