If /cgi-bin/koha/mainpage.pl?logout.x=1 is hit when the user is not logged in, a 500 is displayed. Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40
Created attachment 138147 [details] [review] Bug 31244: Fix 500 if logout and not logged in Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40 Test plan: Open a private window Hit /cgi-bin/koha/mainpage.pl?logout.x=1
Created attachment 138148 [details] [review] Bug 31244: Fix 500 if logout and not logged in Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40 Test plan: Open a private window Hit /cgi-bin/koha/mainpage.pl?logout.x=1 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described - signing off. Thanks for the patch!
Created attachment 138188 [details] [review] Bug 31244: Fix 500 if logout and not logged in Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40 Test plan: Open a private window Hit /cgi-bin/koha/mainpage.pl?logout.x=1 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
Won't backport to 21.11.x. Issue not reproduced + the patch breaks perl compilation. ''' Starting Z39.50/SRU daemon for kohadev:Global symbol "$auth_state" requires explicit package name (did you forget to declare "my $auth_state"?) at /kohadevbox/koha/C4/Auth.pm line 982. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/C4/Auth.pm line 2001. '''
This also affects 21.11.x I'm not sure how you were getting the error you suggest you have Arthur.. we don't introduce auth_state here at all.
It's easy to replicate in the shibboleth environment.. it's very hard without.
OK.. I see.. the conflict comes out really wierd.. I'll drop a 21.11.x specific patch here in a few minutes.
Created attachment 145696 [details] [review] Bug 31244: [21.11.x] Fix 500 if logout and not logged in Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40 Test plan: Open a private window Hit /cgi-bin/koha/mainpage.pl?logout.x=1 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Rebased for 21.11.x Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145717 [details] [review] Bug 31244: [21.11.x] Fix 500 if logout and not logged in Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985 C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186 C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40 Test plan: Open a private window Hit /cgi-bin/koha/mainpage.pl?logout.x=1 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Rebased for 21.11.x Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
applied to 21.11.x for 21.11.16
Not backported to 21.05.x