Bug 31246 - <span> displayed in 'Additional fields' section
Summary: <span> displayed in 'Additional fields' section
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on: 30733
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-27 12:48 UTC by Tomás Cohen Arazi
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05


Attachments
Bug 31246: <span> displayed in 'Additional fields' section (1.66 KB, patch)
2022-07-27 12:57 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 31246: <span> displayed in 'Additional fields' section (1.81 KB, patch)
2022-07-27 13:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 31246: <span> displayed in 'Additional fields' section (1.86 KB, patch)
2022-07-28 00:02 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2022-07-27 12:48:59 UTC
Introduced by bug 30733.
Comment 1 Tomás Cohen Arazi 2022-07-27 12:57:32 UTC
Created attachment 138176 [details] [review]
Bug 31246: <span> displayed in 'Additional fields' section

This patch avoids escaping HMTL data in the additional fields section.

To test:
1. Open the additional fields section
   http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/additional-fields.pl
=> FAIL: there are some nasty <span> </span> texts in there
2. Apply this patch
3. Reload
=> SUCCESS: Things display nicely again!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Biblibre Sandboxes 2022-07-27 13:18:12 UTC
Created attachment 138179 [details] [review]
Bug 31246: <span> displayed in 'Additional fields' section

This patch avoids escaping HMTL data in the additional fields section.

To test:
1. Open the additional fields section
   http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/additional-fields.pl
=> FAIL: there are some nasty <span> </span> texts in there
2. Apply this patch
3. Reload
=> SUCCESS: Things display nicely again!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Comment 3 Victor Grousset/tuxayo 2022-07-28 00:02:00 UTC
Created attachment 138190 [details] [review]
Bug 31246: <span> displayed in 'Additional fields' section

This patch avoids escaping HMTL data in the additional fields section.

To test:
1. Open the additional fields section
   http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/additional-fields.pl
=> FAIL: there are some nasty <span> </span> texts in there
2. Apply this patch
3. Reload
=> SUCCESS: Things display nicely again!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2022-07-28 00:02:23 UTC
Works, qa script happy, code looks good, passing QA :)
Comment 5 Tomás Cohen Arazi 2022-07-28 13:15:23 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-09-02 20:26:13 UTC
Backported to 22.05.x for 22.05.05
Comment 7 Arthur Suzuki 2022-09-14 09:56:19 UTC
won't backport on 21.11.x (depends on 30733)